Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate information icon resources #2734

Merged
merged 1 commit into from
Mar 28, 2019
Merged

Remove duplicate information icon resources #2734

merged 1 commit into from
Mar 28, 2019

Conversation

domdomegg
Copy link
Member

Description

Works on fixing #2643

What changes did you make and why?

Merged the 3 copies of the info icon which just had different colours, using the android:tint attribute instead.

Tests performed

Tested 2.10.1-debug-merge-duplicate-i-icons~cf5980123 on API levels 28 and 19

Screenshots

There are no visible changes to the app:

Home Achievements Media details Nav drawer
Screenshot_1553430571 Screenshot_1553430578 Screenshot_1553430588 Screenshot_1553430591

@codecov-io
Copy link

Codecov Report

Merging #2734 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2734   +/-   ##
======================================
  Coverage    2.72%   2.72%           
======================================
  Files         267     267           
  Lines       12801   12801           
  Branches     1137    1137           
======================================
  Hits          349     349           
  Misses      12426   12426           
  Partials       26      26

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbab7dd...cf59801. Read the comment docs.

@domdomegg domdomegg mentioned this pull request Mar 28, 2019
13 tasks
@maskaravivek
Copy link
Member

Works well for me. Checked both light mode and dark mode. :)

@maskaravivek maskaravivek merged commit 4071d66 into commons-app:master Mar 28, 2019
@domdomegg domdomegg deleted the merge-duplicate-i-icons branch March 28, 2019 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants