Simplify welcome layouts #2741
Merged
Simplify welcome layouts #2741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2741 +/- ##
=========================================
+ Coverage 3.42% 3.43% +<.01%
=========================================
Files 246 246
Lines 12193 12182 -11
Branches 1071 1071
=========================================
Hits 418 418
+ Misses 11744 11733 -11
Partials 31 31
Continue to review full report at Codecov.
|
Files that might be useful for people in the future looking at this PR, that I compiled from older versions of the app
|
|
Tested Welcome activity works All automated tests pass |
neslihanturan
approved these changes
Apr 2, 2019
|
@neslihanturan Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Works on #2643
What changes did you make and why?
Refactored welcome layouts so they're much more structurally similar, moved repeatedly used bullet to it's own file, removed a load of unused xml properties.
Tests performed
Tested
2.10.1-debug-refactor-welcome-layouts~c8f018810in portrait modeTested
2.10.1-debug-refactor-welcome-layouts~c23e6c82fin portrait and landscape mode