-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify welcome layouts #2741
Simplify welcome layouts #2741
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2741 +/- ##
=========================================
+ Coverage 3.42% 3.43% +<.01%
=========================================
Files 246 246
Lines 12193 12182 -11
Branches 1071 1071
=========================================
Hits 418 418
+ Misses 11744 11733 -11
Partials 31 31
Continue to review full report at Codecov.
|
Tested Welcome activity works All automated tests pass |
@neslihanturan Thanks for merging! |
Description
Works on #2643
What changes did you make and why?
Refactored welcome layouts so they're much more structurally similar, moved repeatedly used bullet to it's own file, removed a load of unused xml properties.
Tests performed
Tested
2.10.1-debug-refactor-welcome-layouts~c8f018810
in portrait modeTested
2.10.1-debug-refactor-welcome-layouts~c23e6c82f
in portrait and landscape mode