Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary tags from string resources #2782

Closed
domdomegg opened this issue Mar 28, 2019 · 4 comments · Fixed by #3310
Closed

Remove unnecessary tags from string resources #2782

domdomegg opened this issue Mar 28, 2019 · 4 comments · Fixed by #3310

Comments

@domdomegg
Copy link
Member

Summary:

NB: This has potential merge conflicts with #2741, so probably best to wait until that's merged before working on this (or work on just the ones outside WelcomeActivity).

Would be ideal to remove any tags like CDATA or <u> from string resources. There are probably more but the ones I know about are the 'More information' link from WelcomeActivity, and all the links from AboutActivity. Ideally we should store just the link text in strings.xml, then use a Spannable / similar to give the links an underline, and use onClick listeners with either lambda functions or Butterknife to call Utils.handleWebUrl.

Would you like to work on the issue?

No, but this would be a perfect first issue (when #2741 merged)

@ronanb80
Copy link
Contributor

I can take a look in to this when #2741 is merged

@domdomegg
Copy link
Member Author

To be assigned to @ronanb80 once #2741 merged

@bistaastha
Copy link
Contributor

Hi. Can I work on this?

@nicolas-raoul
Copy link
Member

@bistaastha OK it is yours :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants