Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hyundai: Car Port for Nexo 2021 #933

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

Hyundai: Car Port for Nexo 2021 #933

wants to merge 10 commits into from

Conversation

sunnyhaibin
Copy link
Contributor

@sunnyhaibin sunnyhaibin commented Sep 4, 2023 •
edited
Loading

Checklist

  • added entry to CarInfo in selfdrive/car/*/values.py and ran selfdrive/car/docs.py to generate new docs
  • test route added to routes.py
  • route with stock system: a74afe0cf708748f|2023-09-02--19-56-27
  • route with openpilot: a74afe0cf708748f|2023-09-10--11-18-49
  • harness Type: Hyundai H
  • architecture: CAN

Link to all physical parts during installation

Requires

Thanks to community 2021 Hyundai Nexo owner SimonYang402.

Defines gear shifter and accelerator pedal signals for FCEV cars.

Gear Shifter Accelerator Pedal
a74afe0cf708748f|2023-09-04--18-31-39 a74afe0cf708748f|2023-09-05--19-40-54
Image Image

Supersedes commaai/openpilot#29771

@sunnyhaibin sunnyhaibin mentioned this pull request Sep 4, 2023
Closed
6 tasks
@github-actions github-actions bot added DBC signals car related to opendbc/car/ hyundai labels Aug 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 20, 2024 •
edited
Loading

Thanks for contributing to opendbc! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • include a route or your device' dongle ID if relevant

This was referenced Aug 20, 2024
Draft
Closed
@sunnyhaibin sunnyhaibin changed the title Hyundai CAN: gear shifter and accelerator pedal signals for FCEV Hyundai: Car Port for Nexo 2021 Sep 23, 2024
jyoung8607
jyoung8607 requested changes Sep 25, 2024
View reviewed changes
opendbc/car/hyundai/interface.py Outdated Show resolved Hide resolved
opendbc/car/hyundai/values.py Outdated Show resolved Hide resolved
@jyoung8607 jyoung8607 self-assigned this Sep 25, 2024
@jyoung8607 jyoung8607 marked this pull request as draft September 25, 2024 00:02
@sunnyhaibin sunnyhaibin mentioned this pull request Sep 25, 2024
Merged
@sunnyhaibin sunnyhaibin marked this pull request as ready for review September 25, 2024 03:42
@sunnyhaibin
Copy link
Contributor Author

sunnyhaibin commented Sep 25, 2024 •
edited
Loading

Awaiting test route from user simon402_61863 (Discord).

@sunnyhaibin sunnyhaibin marked this pull request as draft September 25, 2024 05:06
@sunnyhaibin
Merge remote-tracking branch 'commaai/opendbc/master' into nexo-2021-…
68240c9 
…port

# Conflicts:
#	opendbc/car/hyundai/carstate.py
#	opendbc/car/torque_data/override.toml
@sunnyhaibin
add test routes
5fcf387
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyoung8607 jyoung8607 jyoung8607 requested changes

Assignees

@jyoung8607 jyoung8607

Labels
car related to opendbc/car/ DBC signals fingerprint hyundai
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunnyhaibin @jyoung8607