Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hyundai: Car Port for Nexo 2021 #1637

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

Hyundai: Car Port for Nexo 2021 #1637

wants to merge 10 commits into from

Conversation

sunnyhaibin
Copy link
Contributor

@sunnyhaibin sunnyhaibin commented Sep 4, 2023 •
edited
Loading

@sunnyhaibin sunnyhaibin mentioned this pull request Sep 4, 2023
Closed
6 tasks
@sshane
Copy link
Contributor

sshane commented Nov 2, 2023

  • Needs tests

@sshane sshane added the car safety vehicle-specific safety code label Nov 2, 2023
@sunnyhaibin sunnyhaibin mentioned this pull request Aug 20, 2024
Draft
6 tasks
jyoung8607
jyoung8607 suggested changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@jyoung8607 jyoung8607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable at a glance, but as Shane mentioned, will need a test added. That's why CI isn't passing, because the FCEV code path isn't exercised at all.

@jyoung8607 jyoung8607 self-assigned this Sep 25, 2024
@sunnyhaibin
Copy link
Contributor Author

Looks reasonable at a glance, but as Shane mentioned, will need a test added. That's why CI isn't passing, because the FCEV code path isn't exercised at all.

Unite test updated and all passed.

jyoung8607
jyoung8607 approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@jyoung8607 jyoung8607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jyoung8607 jyoung8607 requested a review from sshane September 25, 2024 04:51
@sunnyhaibin
Copy link
Contributor Author

sunnyhaibin commented Sep 25, 2024 •
edited
Loading

Awaiting test route from user simon402_61863 (Discord).

@sunnyhaibin sunnyhaibin marked this pull request as draft September 25, 2024 05:07
@jyoung8607
Copy link
Collaborator

The actual code here is GTM, but the original public test route has gone away, and we shouldn't merge this component without an immediate path to merging the opendbc port.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyoung8607 jyoung8607 jyoung8607 approved these changes

@sshane sshane Awaiting requested review from sshane

Assignees

@jyoung8607 jyoung8607

Labels
car safety vehicle-specific safety code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sunnyhaibin @sshane @jyoung8607