Hyundai: dashcam FCEV #1973
Merged
Hyundai: dashcam FCEV #1973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
car
sunnyhaibin
added a commit
to sunnypilot/opendbc
that referenced
this pull request
Mar 11, 2025
This reverts commit 6254215.
This was referenced Mar 11, 2025
chrispypatt
pushed a commit
to chrispypatt/opendbc
that referenced
this pull request
Mar 12, 2025
* Disable FCEV * coverage * fixme * misra misra
chrispypatt
pushed a commit
to chrispypatt/opendbc
that referenced
this pull request
Mar 12, 2025
* Revert "Hyundai: dashcam FCEV (commaai#1973)" This reverts commit 6254215. * Hyundai: Fix FCEV RX check and move out of dashcam * less duplication * line * same * add missing test --------- Co-authored-by: Shane Smiskol <shane@smiskol.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dashcamming the car from #933 as it's missing an rx check
Bug is in the safety tests in #1903. @sunnyhaibin can you fix?