Hyundai: Fix FCEV RX check and move out of dashcam #1974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
car
sshane
reviewed
Mar 12, 2025
Comment on lines
307
to
317
| if (hyundai_fcev_gas_signal) { | ||
| SET_RX_CHECKS(hyundai_fcev_long_rx_checks, ret); | ||
| } else { | ||
| SET_RX_CHECKS(hyundai_long_rx_checks, ret); | ||
| } | ||
|
|
||
| if (hyundai_camera_scc) { | ||
| SET_TX_MSGS(HYUNDAI_CAMERA_SCC_LONG_TX_MSGS, ret); | ||
| } else { | ||
| SET_TX_MSGS(HYUNDAI_LONG_TX_MSGS, ret); | ||
| } |
There was a problem hiding this comment.
@sunnyhaibin even though it's longer, this is easier to read
There was a problem hiding this comment.
and it finds a missing test!
chrispypatt
pushed a commit
to chrispypatt/opendbc
that referenced
this pull request
Mar 12, 2025
* Revert "Hyundai: dashcam FCEV (commaai#1973)" This reverts commit 6254215. * Hyundai: Fix FCEV RX check and move out of dashcam * less duplication * line * same * add missing test --------- Co-authored-by: Shane Smiskol <shane@smiskol.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1973.
Tested with #1903 as base and it passed
test_modelslocally.Split
0x91into its own macro to ensure RX check is included for FCEV accelerator pedal pressed.