liveTracks: bool error fields #2001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshane
force-pushed
the
radar-bool-fields
branch
from
4cde539 to
c61900c
Compare
This reverts commit 76b0b0e.
lukasloetkolben
pushed a commit
to lukasloetkolben/opendbc
that referenced
this pull request
Mar 19, 2025
* bool fields * migrate ford * migrate the rest * clean up * same but diff * no struct * Revert "no struct" This reverts commit 76b0b0e.
gadhadar
pushed a commit
to qzwf/opendbc
that referenced
this pull request
Mar 21, 2025
* bool fields * migrate ford * migrate the rest * clean up * same but diff * no struct * Revert "no struct" This reverts commit 76b0b0e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping the struct as it removes the possibility of forgetting to set the valid field when adding a new one