Ford: radar is invalid when in reverse #2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adeebshihadeh
requested changes
Mar 14, 2025
opendbc/car/car.capnp
Outdated
| @@ -307,6 +307,7 @@ struct RadarData @0x888ad6581cf0aacb { | |||
| canError @0; | |||
| fault @1; | |||
| wrongConfig @2; | |||
| unavailableTemporary @3; # radar data is temporarily unavailable due to conditions the car sets | |||
There was a problem hiding this comment.
let's make these bool fields
|
This the same for Hyundai when it's not in Drive gear. |
|
Want to make an issue with a route? |
Opened issue. |
lukasloetkolben
pushed a commit
to lukasloetkolben/opendbc
that referenced
this pull request
Mar 19, 2025
* rename * send empty * revert * cmt * temp unavailable * clean up * fix * fix * fix
gadhadar
pushed a commit
to qzwf/opendbc
that referenced
this pull request
Mar 21, 2025
* rename * send empty * revert * cmt * temp unavailable * clean up * fix * fix * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Radar just sends the last message while in reverse (for everything; tracks, headers, etc.), so we need to detect a stalled scan index and add a fault instead of stop sending liveTracks: