Treat recursive make correctly

[mernst]

No description provided.

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request systematically replaces hardcoded make command invocations with the ${MAKE} variable across three Makefile files: the top-level Makefile, doc/Makefile, and tests/Makefile.common. Specifically, it changes make to ${MAKE} and make -C to ${MAKE} -C in various targets and rules. This modification allows the build system to respect MAKEFLAGS and other recursive make settings that would otherwise be bypassed by direct command invocations.

Possibly related PRs

• Use is-ci.sh from plume-lib #728: Modifies the plume-scripts/update-plume-scripts target invocation, touching the same build automation as this PR
• Update Makefile #736: Updates recursive sub-make invocations in Makefile files, addressing similar build system consistency concerns

Suggested reviewers

• markro49

🚥 Pre-merge checks | ✅ 1

✅ Passed checks (1 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7acdbad and 7ce2d52.

📒 Files selected for processing (3)

• Makefile
• doc/Makefile
• tests/Makefile.common

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)

• GitHub Check: codespecs.daikon (typecheck_latest_part2_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (typecheck_latest_part1_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (typecheck_latest_part3_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (typecheck_bundled_part2_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (typecheck_bundled_part1_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (typecheck_bundled_part3_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (kvasir_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (nonquick_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (misc_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (nontxt_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (quick_ubuntu_jdk25)

🔇 Additional comments (3)

doc/Makefile (1)

66-70: LGTM!

Using ${MAKE} for recursive make invocations is the correct approach. This ensures that command-line options (like -j for parallel builds) and MAKEFLAGS are properly propagated to the sub-make, which is consistent with the existing patterns in this file.

Makefile (1)

624-629: LGTM!

These changes correctly replace hardcoded make with ${MAKE} in the daikon.tar/daikon.zip target, ensuring proper propagation of MAKEFLAGS and parallel build options. This is consistent with the extensive use of ${MAKE} throughout the rest of this Makefile.

tests/Makefile.common (1)

287-291: LGTM!

Both targets now correctly use ${MAKE} for recursive invocations to compile the Java code when the required class files are missing. This ensures consistent behavior with the rest of the Makefile infrastructure and proper propagation of build options.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}