Rename target

[mernst]

Merge after #755.

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request reorganizes plume scripts paths and build targets in Makefile configurations. The PLUMESCRIPTS path is updated from $(DAIKONDIR)/.plume-scripts to $(DAIKONDIR)/utils/plume-scripts. The corresponding make target is renamed from update-plume-scripts to update-plume-scripts-in-utils, with both doc/Makefile and java/Makefile adjusted to reference the new target and path structure. Total changes span 10 lines across two Makefile files.

Possibly related PRs

• Use is-ci.sh from plume-lib #728: Directly related changes that rename the Makefile target update-plume-scripts to update-plume-scripts-in-utils and adjust PLUMESCRIPTS paths.

Suggested reviewers

• markro49

🚥 Pre-merge checks | ✅ 1

✅ Passed checks (1 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between df8b554 and f8e16ed.

📒 Files selected for processing (2)

• doc/Makefile
• java/Makefile

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)

• GitHub Check: codespecs.daikon (typecheck_bundled_part3_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (typecheck_latest_part3_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (typecheck_latest_part1_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (typecheck_bundled_part2_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (typecheck_latest_part2_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (misc_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (kvasir_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (typecheck_bundled_part1_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (nonquick_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (nontxt_ubuntu_jdk25)
• GitHub Check: codespecs.daikon (quick_ubuntu_jdk25)

🔇 Additional comments (4)

java/Makefile (3)

12-12: LGTM!

The path update from .plume-scripts to utils/plume-scripts aligns with the PR's goal of reorganizing plume scripts into the utils directory. The conditional assignment ?= preserves user override capability.

---

641-642: LGTM!

The directory prerequisite rule correctly invokes the renamed target via the parent Makefile.

---

647-649: LGTM!

The new .PHONY target is correctly defined and properly delegates to the parent Makefile. This ensures the target can be invoked from the java directory while keeping the implementation centralized.

doc/Makefile (1)

69-70: The recursive make invocation is correct.

The parent Makefile defines update-plume-scripts-in-utils as a .PHONY target with proper git pull/clone logic. The rule correctly references it via ${MAKE} -C .. update-plume-scripts-in-utils.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}