sync #25
Merged
sync #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using zend_string whenever relevant too. Close GH-13582.
Unlike IntlDateFormatter::parse, the timezone is updated accordingly. Close GH-13779
These were removed via 0904dd3.
Start using fast ZPP in very commonly used DOM functions, and also try to unify some branches by using RETURN_BOOL where appropriate.
Implementation for the "Adding bcround, bcfloor and bcceil to BCMath" RFC: https://wiki.php.net/rfc/adding_bcround_bcfloor_bcceil_to_bcmath * Separated round mode into separate header file Co-authored-by: Gina Peter Banyard <girgias@php.net>
unpriviliged_userfaultfd is set to 0 by default. Since Linux 5.11 handling memory ranges from the user-space is allowed with the `UFFD_USER_MODE_ONLY` fd open mode flag.
The php_random.h header already defines them as `PHPAPI` and they actually are part of the public API. Co-authored-by: Arnaud Le Blanc <arnaud.lb@gmail.com>
…ity references libxml doesn't do reference counting inside its node types. It's possible to remove an entity declaration out of the document, but then entity references will keep pointing to that stale declaration. This will cause crashes. One idea would be to check when a declaration is removed, to trigger a hook that updates all references. However this means we have to keep track of all references somehow, which would be a high-overhead solution. The solution in this patch makes sure that the fields are always updated before they are read. Closes GH-14089.
Fixes nightly builds where ZEND_RC_DEBUG is enabled
* PHP-8.2: Fix crash when calling childNodes next() when iterator is exhausted Fix references not handled correctly in C14N Fix crashes when entity declaration is removed while still having entity references
* PHP-8.3: Fix crash when calling childNodes next() when iterator is exhausted Fix references not handled correctly in C14N Fix crashes when entity declaration is removed while still having entity references
This affects only function JIT.
Non-static closures are guaranteed to have $this. The existing comment highlights this, but fails to handle it correctly. Closes GH-14181
Symbol isn't defined on Windows and is redundant since the SQLite library is required for ext/pdo_sqlite and isn't bundled in php-src anymore.
The created files have the same filename, creating conflicts. Fix this by adding a unique suffix.
* PHP-8.2: Fix nightly test failure (#14251)
* PHP-8.3: Fix nightly test failure (#14251)
…onstructor (#14254) `zend_call_method_with_1_params()` causes needless overhead, due to the capability of looking up the function by name. It’s also very rarely used (only in ext/spl). `zend_call_known_function()` is the standard methodology to call a known function and going through `Z_OBJCE_P()` avoids the repeated hardcoding of the CE name.
Avoid unnecessary memset from `_bc_do_sub`
This is used in Makefile when building mysqlnd as shared to get zlib and crypto libraries linked in the mysqlnd.so (-lz -lcrypto). For static build these are in the resulting binary like before.
* PHP-8.2: Clear mysql error in fetch_into
* PHP-8.3: Clear mysql error in fetch_into
* PHP-8.3: Make the `fcc` parameter `const` in `zend_call_known_fcc` (#14259)
Apply the same changes as #14180 to _bc_do_add.
This syncs build system gaps of some extensions' definitions being defined on Windows and some on *nix. These are not used anywhere and are only defined in some build system and not the other: * HAVE_INTL (was present only on Windows) * HAVE_PDO_DBLIB (was present only on Autotools) * HAVE_PDO_FIREBIRD (was present only on Autotools) * HAVE_TOKENIZER (was present only on Windows)
This constant is only available if it is defined by libxml2, but it is never defined because the minimum version of libxml2 that we support had removed XML_GLOBAL_NAMESPACE already.
This reduces -Wunused-variable and -Wunused-but-set-variable warnings generated in the Autoconf's config.log to comply with possible stricter default compiler configuration on the system to avoid having false results.
By default compilers may not treat attribute warnings as errors when encountering an unknown __attribute__, unless some error option is provided (-Werror=attributes, -Werror=unknown-attributes, -Werror...). This fixes the check and wraps it into a separate M4 macro to be extendable in the future if needed. It checks if conftest.err file was generated by the compilation check when warnings appear. Also, PHP check is a bit customized by using __alignof__ keyword, so it is left in there for now to not break existing checks.
Arithmetic on NULL pointers is undefined.
* PHP-8.2: Fix undefined behaviour in fastcgi.c (#14269)
* PHP-8.3: Fix undefined behaviour in fastcgi.c (#14269)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.