Skip to content

Class redeclaration print location #13999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Class redeclaration print location #13999

wants to merge 3 commits into from

Conversation

iluuu1994
Copy link
Member

No description provided.

@iluuu1994 iluuu1994 requested a review from kocsismate April 19, 2024 17:47
jorgsowa
jorgsowa reviewed Apr 20, 2024
View reviewed changes
Copy link
Contributor

@jorgsowa jorgsowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. It's a small change but useful for debugging. I left some comments, I hope it's helpful and I don't waste your time.

@iluuu1994
Copy link
Member Author

I hope it's helpful and I don't waste your time.

Please, don't worry about that! Suggestions rarely waste time in my experience. Arguments are are a different story. 😅

@iluuu1994 iluuu1994 closed this in 1c30c5e Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bwoebi bwoebi bwoebi left review comments

@kocsismate kocsismate Awaiting requested review from kocsismate

@dstogov dstogov Awaiting requested review from dstogov dstogov will be requested when the pull request is marked ready for review dstogov is a code owner

+1 more reviewer

@jorgsowa jorgsowa jorgsowa left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Category: Build System Category: Engine Extension: opcache Extension: pcre

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iluuu1994 @bwoebi @jorgsowa