sapi/phpdbg: Update of userfaultfd workflow.#13955
Merged
devnexen merged 1 commit intophp:masterfrom Apr 30, 2024
Merged
Conversation
Member
Author
|
@nielsdos do you know well enough here ? :) |
ndossche
approved these changes
Apr 30, 2024
Member
ndossche
left a comment
ndossche
left a comment
There was a problem hiding this comment.
Seems right, we don't need to catch kernel faults. I only have a wording nit.
sapi/phpdbg/phpdbg_watch.c
Outdated
| PHPDBG_G(watch_userfaultfd) = syscall(SYS_userfaultfd, O_CLOEXEC); | ||
| int flags = O_CLOEXEC; | ||
| #ifdef UFFD_USER_MODE_ONLY | ||
| // unpriviliged userfaultfd being disabled by default, |
Member
There was a problem hiding this comment.
Suggested change
| // unpriviliged userfaultfd being disabled by default, | |
| // unpriviliged userfaultfd are disabled by default, |
unpriviliged_userfaultfd is set to 0 by default. Since Linux 5.11 handling memory ranges from the user-space is allowed with the `UFFD_USER_MODE_ONLY` fd open mode flag.
devnexen
force-pushed
the
phpdbg_userfaultfd_update
branch
from
4bf9c1f to
7a3cc28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unpriviliged_userfaultfd is set to 0 by default. Since Linux 5.11 handling memory ranges from the user-space is allowed with the
UFFD_USER_MODE_ONLYfd open mode flag.