Make the fcc parameter const in zend_call_known_fcc#14259
Merged
TimWolla merged 1 commit intophp:PHP-8.3from May 17, 2024
Merged
Make the fcc parameter const in zend_call_known_fcc#14259TimWolla merged 1 commit intophp:PHP-8.3from
fcc parameter const in zend_call_known_fcc#14259TimWolla merged 1 commit intophp:PHP-8.3from
Conversation
This makes it legal to call the function from a caller that only has a `const` pointer to the `fcc` to prevent accidental modification.
Member
|
Is it okay to target 8.3? |
Member
|
Should be ABI compatible, so yes. @TimWolla Is there a particular motivation for this? If this is backported, why to 8.3 and not 8.2? |
Member
Author
I have a non-php-src case of FCC being embedded into a larger structure that I'd prefer to access via a
Because the function does not exist in 8.2. It was introduced in #9840. |
iluuu1994
approved these changes
May 17, 2024
Member
iluuu1994
left a comment
iluuu1994
left a comment
There was a problem hiding this comment.
Thanks for the explanation. LGTM then. 🙂
Member
Author
|
CI failures appear unrelated, thus merging:
|
TimWolla
added a commit
that referenced
this pull request
May 17, 2024
* PHP-8.3: Make the `fcc` parameter `const` in `zend_call_known_fcc` (#14259)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it legal to call the function from a caller that only has a
constpointer to thefccto prevent accidental modification.