-
Notifications
You must be signed in to change notification settings - Fork 11.7k
refactor: No more trpc stuff in @calcom/features [3]
#26571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
hbjORbj
wants to merge
215
commits into
main
Choose a base branch
from
refactor/move-trpc-stuff-from-features-to-web
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+604
−438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ircular dependency - Migrate UserTableUser and MemberPermissions types to packages/features/users/types/user-table.ts - Migrate useGeo hook to packages/features/geo/GeoContext.tsx - Migrate buildLegacyRequest to packages/lib/buildLegacyCtx.ts - Migrate Calendar component to packages/features/calendars/weeklyview/components/ - Move test utilities (bookingScenario, fixtures) to packages/features/test/ - Update all imports in packages/features to use new locations - Add re-exports in apps/web for backward compatibility Co-Authored-By: benny@cal.com <sldisek783@gmail.com>
- Delete original calendar component files in apps/web (keep only re-export stubs) - Migrate OutOfOfficeInSlots to packages/features/bookings/components - Convert apps/web OutOfOfficeInSlots to re-export stub - Fix className vs class issue in Calendar.tsx - Fix @calcom/trpc import violation in user-table.ts by using structural type Co-Authored-By: benny@cal.com <sldisek783@gmail.com>
…tes type Co-Authored-By: benny@cal.com <sldisek783@gmail.com>
Co-Authored-By: benny@cal.com <sldisek783@gmail.com>
…from-features-1767632135' into devin/remove-calcom-web-imports-from-features-1767632135
…b-imports-from-features-1767632135
…eb-imports-from-features-1767632135
- Move bookingScenario utilities to tests/libs/bookingScenario - Move fixtures to tests/libs/fixtures - Update all imports in packages/features test files to use new location - Update all imports in apps/web test files to use new location - Eliminates duplication of test utilities between packages/features and apps/web Co-Authored-By: benny@cal.com <sldisek783@gmail.com>
Co-Authored-By: benny@cal.com <sldisek783@gmail.com>
Co-Authored-By: benny@cal.com <sldisek783@gmail.com>
…rom hook files Co-Authored-By: benny@cal.com <sldisek783@gmail.com>
…uff-from-features-to-web
hbjORbj
commented
Jan 19, 2026
| }; | ||
| }); | ||
|
|
||
| const noop = () => { |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
redundant
…flow Co-Authored-By: benny@cal.com <sldisek783@gmail.com>
… types Co-Authored-By: benny@cal.com <sldisek783@gmail.com>
…c import Co-Authored-By: benny@cal.com <sldisek783@gmail.com>
… apps/web - Remove @calcom/trpc import from @calcom/features/bookings/Booker/types.ts - Make UseCalendarsReturnType and useScheduleForEventReturnType generic - Make WrappedBookerPropsMain and related types generic - Add concrete types in apps/web/modules/bookings/types.ts using RouterOutputs - Update all usage sites in apps/web to import from local types file Co-Authored-By: benny@cal.com <sldisek783@gmail.com>
…uff-from-features-to-web
- Fix useSegments import path in bookings-view.tsx (use @calcom/web/modules) - Fix useFlags import path in team-invite-view.tsx (use @calcom/web/modules) - Revert BookerWebWrapperAtomProps to not include WrappedBookerProps (internal props) - Change invalidate return type to Promise<unknown> for React Query compatibility Co-Authored-By: benny@cal.com <sldisek783@gmail.com>
…uff-from-features-to-web
…s/index.tsx, Booker.tsx, and Booker.test.tsx Co-Authored-By: benny@cal.com <sldisek783@gmail.com>
Co-Authored-By: benny@cal.com <sldisek783@gmail.com>
…uff-from-features-to-web
This was referenced Jan 25, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Moves TRPC-driven UI out of
packages/featuresintoapps/web/modules, removing circular dependencies and stabilizing builds.Impact:
@calcom/trpcimports frompackages/featuresKey changes:
@calcom/featuresto@calcom/web/modulesICalendarSwitchPropsinterface directly in@calcom/uito fix circular dependencyUseCalendarsReturnType,useScheduleForEventReturnType, andWrappedBookerPropsMaingeneric to remove@calcom/trpcimports from@calcom/featurespackages/features/testtotests/libsMandatory Tasks (DO NOT REMOVE)