Skip to content

Conversation

@hbjORbj
Copy link
Contributor

@hbjORbj hbjORbj commented Jan 25, 2026

What does this PR do?

This is the second PR extracting simple migrations from #26571 (which is too large to review at 244 files).

Moves tRPC-dependent UI components from packages/features to apps/web/modules to eliminate circular dependencies:

Feature flags:

  • FlagAdminList.tsx, AssignFeatureSheet.tsxapps/web/modules/feature-flags/components/
  • hooks/index.tsapps/web/modules/feature-flags/hooks/
  • flag-listing-view.tsxapps/web/modules/feature-flags/views/

Calendars:

  • AdditionalCalendarSelector.tsx, NoAvailabilityDialog.tsxapps/web/modules/calendars/components/
  • DatePicker.tsxapps/web/modules/calendars/DatePicker.tsx
  • DestinationCalendarSelector.tsxpackages/features/calendars/components/ (reorganized within packages/features)

Schedules:

  • Schedule.tsx, NewScheduleButton.tsxapps/web/modules/schedules/components/
  • date-override-list.test.tsx moved with component

Type refactoring (to remove tRPC RouterOutputs dependency):

  • DateOverrideList.tsx - replaced RouterOutputs["viewer"]["travelSchedules"]["get"] with local TravelSchedule interface
  • ScheduleListItem.tsx - replaced RouterOutputs["viewer"]["availability"]["list"]["schedules"][number] with local Schedule interface
  • DestinationCalendarSelector.tsx - replaced RouterOutputs["viewer"]["calendars"]["connectedCalendars"] with local interfaces

All import paths updated across the codebase including platform atoms.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. N/A - no documentation changes needed.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  1. Run type checking: yarn type-check:ci --force
  2. Run linting: yarn lint
  3. Verify availability settings page works correctly
  4. Verify feature flags admin page loads

Human Review Checklist

  • Verify the local interfaces in DateOverrideList.tsx, ScheduleListItem.tsx, and DestinationCalendarSelector.tsx match the original RouterOutputs types
  • Confirm all import paths are correctly updated
  • Check that no other files still import from the old locations

…m packages/features to apps/web/modules

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>
@devin-ai-integration
Copy link
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

hbjORbj and others added 8 commits January 26, 2026 02:50
…and update imports

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>
…dars-schedules-to-web' into devin/1769362470-move-auth-calendars-schedules-to-web

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>
…dars-schedules-to-web' into devin/1769362470-move-auth-calendars-schedules-to-web
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jan 25, 2026
@github-actions
Copy link
Contributor

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants