-
Notifications
You must be signed in to change notification settings - Fork 11.7k
refactor: move hooks and stores from packages/features to apps/web/modules #27221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move hooks and stores from packages/features to apps/web/modules #27221
Conversation
… to apps/web/modules This is part of the larger effort to move tRPC-dependent UI components from packages/features to apps/web/modules to eliminate circular dependencies. Changes: - Move BookingHistory.tsx and BookingHistoryPage.tsx to apps/web/modules/booking-audit/components/ - Update imports in apps/web to use the new location Co-Authored-By: benny@cal.com <sldisek783@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
…odules Co-Authored-By: benny@cal.com <sldisek783@gmail.com>
…dules - Move useAppsData hook from packages/features/apps/hooks to apps/web/modules/apps/hooks - Move onboardingStore from packages/features/ee/organizations/lib to apps/web/modules/ee/organizations/lib - Move useWelcomeModal hook from packages/features/ee/organizations/hooks to apps/web/modules/ee/organizations/hooks - Move useAgentsData hook from packages/features/ee/workflows/hooks to apps/web/modules/ee/workflows/hooks - Update all import paths in consuming files Co-Authored-By: benny@cal.com <sldisek783@gmail.com>
Co-Authored-By: benny@cal.com <sldisek783@gmail.com>
| @@ -29,12 +29,6 @@ export const initFormbricks = ({ | |||
| } | |||
| }; | |||
|
|
|||
| export const trackFormbricksAction = (eventName: string, properties: Record<string, string> = {}) => { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extracted to apps/web/modules/formbricks/lib/trackFormbricksAction.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 30 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="apps/web/modules/formbricks/lib/trackFormbricksAction.ts">
<violation number="1" location="apps/web/modules/formbricks/lib/trackFormbricksAction.ts:4">
P3: Centralize Formbricks env values in a shared constants/config module and read from that instead of accessing process.env directly here.
(Based on your team's feedback about centralizing env-derived configuration.) [FEEDBACK_USED]</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Devin AI is addressing Cubic AI's review feedbackA Devin session has been created to address the issues identified by Cubic AI. |
|
I reviewed the Cubic AI feedback on this PR. The only issue identified has a confidence score of 7/10, which is below the 9/10 threshold for automated fixes. Issue skipped:
Since this is a P3 suggestion with moderate confidence, it may be worth considering in a follow-up PR if the team agrees with the approach, but it doesn't meet the threshold for immediate automated changes. |
E2E results are ready! |
Devin AI is addressing Cubic AI's review feedbackA Devin session has been created to address the issues identified by Cubic AI. |
…-booking-audit-client-to-web
…-booking-audit-client-to-web
What does this PR do?
This PR moves tRPC-dependent UI components from
packages/featurestoapps/web/modulesas part of the larger effort to relocate these components closer to where they're used.This is extracted from #26571 which was too large to review effectively.
Changes:
1. Booking-audit migration:
BookingHistory.tsxandBookingHistoryPage.tsxfrompackages/features/booking-audit/client/components/toapps/web/modules/booking-audit/components/2. Formbricks migration:
formbricks-client.tsfrompackages/features/formbricks/toapps/web/modules/formbricks/, split into:hooks/useFormbricks.ts- the React hook for initializing Formbrickslib/trackFormbricksAction.ts- the tracking utility function3. useAppsData hook migration:
Move
useAppsData.tsfrompackages/features/apps/hooks/toapps/web/modules/apps/hooks/Update imports in 3 files:
EventAppsTabEventTypeAppSettingsWrapperEventPaymentsTabPlatformWrapper4. onboardingStore migration:
onboardingStore.tsfrompackages/features/ee/organizations/lib/toapps/web/modules/ee/organizations/lib/onboardingStore.test.tsalongside the source file5. useWelcomeModal hook migration:
useWelcomeModal.tsfrompackages/features/ee/organizations/hooks/toapps/web/modules/ee/organizations/hooks/6. useAgentsData hook migration:
Move
useAgentsData.tsfrompackages/features/ee/workflows/hooks/toapps/web/modules/ee/workflows/hooks/Update imports in 1 file:
WorkflowDetailsPageMandatory Tasks (DO NOT REMOVE)