Skip to content

Conversation

@hbjORbj
Copy link
Contributor

@hbjORbj hbjORbj commented Jan 25, 2026

What does this PR do?

This PR moves tRPC-dependent UI components from packages/features to apps/web/modules as part of the larger effort to relocate these components closer to where they're used.

This is extracted from #26571 which was too large to review effectively.

Changes:

1. Booking-audit migration:

  • Move BookingHistory.tsx and BookingHistoryPage.tsx from packages/features/booking-audit/client/components/ to apps/web/modules/booking-audit/components/
  • Update imports in 2 files that use these components

2. Formbricks migration:

  • Move formbricks-client.ts from packages/features/formbricks/ to apps/web/modules/formbricks/, split into:
    • hooks/useFormbricks.ts - the React hook for initializing Formbricks
    • lib/trackFormbricksAction.ts - the tracking utility function
  • Update imports in 6 files that use formbricks

3. useAppsData hook migration:

  • Move useAppsData.ts from packages/features/apps/hooks/ to apps/web/modules/apps/hooks/

  • Update imports in 3 files:

    • EventAppsTab
    • EventTypeAppSettingsWrapper
    • EventPaymentsTabPlatformWrapper

4. onboardingStore migration:

  • Move onboardingStore.ts from packages/features/ee/organizations/lib/ to apps/web/modules/ee/organizations/lib/
  • Move onboardingStore.test.ts alongside the source file
  • Update imports in 7 organization onboarding components

5. useWelcomeModal hook migration:

  • Move useWelcomeModal.ts from packages/features/ee/organizations/hooks/ to apps/web/modules/ee/organizations/hooks/
  • Update imports in 3 files

6. useAgentsData hook migration:

  • Move useAgentsData.ts from packages/features/ee/workflows/hooks/ to apps/web/modules/ee/workflows/hooks/

  • Update imports in 1 file:

    • WorkflowDetailsPage

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. N/A - no documentation changes needed.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works. N/A - pure file moves with no logic changes.

… to apps/web/modules

This is part of the larger effort to move tRPC-dependent UI components from packages/features to apps/web/modules to eliminate circular dependencies.

Changes:
- Move BookingHistory.tsx and BookingHistoryPage.tsx to apps/web/modules/booking-audit/components/
- Update imports in apps/web to use the new location

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>
@devin-ai-integration
Copy link
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

…odules

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>
@devin-ai-integration devin-ai-integration bot changed the title refactor: move booking-audit client components from packages/features to apps/web/modules refactor: move booking-audit and formbricks from packages/features to apps/web/modules Jan 25, 2026
…dules

- Move useAppsData hook from packages/features/apps/hooks to apps/web/modules/apps/hooks
- Move onboardingStore from packages/features/ee/organizations/lib to apps/web/modules/ee/organizations/lib
- Move useWelcomeModal hook from packages/features/ee/organizations/hooks to apps/web/modules/ee/organizations/hooks
- Move useAgentsData hook from packages/features/ee/workflows/hooks to apps/web/modules/ee/workflows/hooks
- Update all import paths in consuming files

Co-Authored-By: benny@cal.com <sldisek783@gmail.com>
@devin-ai-integration devin-ai-integration bot changed the title refactor: move booking-audit and formbricks from packages/features to apps/web/modules refactor: move hooks and stores from packages/features to apps/web/modules Jan 25, 2026
Co-Authored-By: benny@cal.com <sldisek783@gmail.com>
@@ -29,12 +29,6 @@ export const initFormbricks = ({
}
};

export const trackFormbricksAction = (eventName: string, properties: Record<string, string> = {}) => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extracted to apps/web/modules/formbricks/lib/trackFormbricksAction.ts

@hbjORbj hbjORbj marked this pull request as ready for review January 25, 2026 17:40
@hbjORbj hbjORbj requested review from a team as code owners January 25, 2026 17:40
@graphite-app graphite-app bot added foundation core area: core, team members only labels Jan 25, 2026
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 30 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="apps/web/modules/formbricks/lib/trackFormbricksAction.ts">

<violation number="1" location="apps/web/modules/formbricks/lib/trackFormbricksAction.ts:4">
P3: Centralize Formbricks env values in a shared constants/config module and read from that instead of accessing process.env directly here.

(Based on your team's feedback about centralizing env-derived configuration.) [FEEDBACK_USED]</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@github-actions
Copy link
Contributor

Devin AI is addressing Cubic AI's review feedback

A Devin session has been created to address the issues identified by Cubic AI.

View Devin Session

@devin-ai-integration
Copy link
Contributor

I reviewed the Cubic AI feedback on this PR. The only issue identified has a confidence score of 7/10, which is below the 9/10 threshold for automated fixes.

Issue skipped:

  • Location: apps/web/modules/formbricks/lib/trackFormbricksAction.ts:4
  • Suggestion: Centralize Formbricks env values in a shared constants/config module
  • Confidence: 7/10

Since this is a P3 suggestion with moderate confidence, it may be worth considering in a follow-up PR if the team agrees with the approach, but it doesn't meet the threshold for immediate automated changes.

@github-actions
Copy link
Contributor

E2E results are ready!

@github-actions
Copy link
Contributor

Devin AI is addressing Cubic AI's review feedback

A Devin session has been created to address the issues identified by Cubic AI.

View Devin Session

@hbjORbj hbjORbj requested a review from keithwillcode January 26, 2026 07:50
@hbjORbj hbjORbj enabled auto-merge (squash) January 26, 2026 12:00
@hbjORbj hbjORbj merged commit 0774a41 into main Jan 26, 2026
49 checks passed
@hbjORbj hbjORbj deleted the devin/1769348296-move-booking-audit-client-to-web branch January 26, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants