-
Notifications
You must be signed in to change notification settings - Fork 11.7k
refactor: move timezone-select, settings, and insights components from packages/features to apps/web/modules #27227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…m packages/features to apps/web/modules Co-Authored-By: benny@cal.com <sldisek783@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
E2E results are ready! |
| @@ -110,14 +110,6 @@ export function WebPushProvider({ children }: ProviderProps) { | |||
| return <WebPushContext.Provider value={contextValue}>{children}</WebPushContext.Provider>; | |||
| } | |||
|
|
|||
| export function useWebPush() { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extracted into apps/web/modules/notifications/hooks/useWebPush.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 31 files
What does this PR do?
This PR is part of a larger effort to break down PR #26571 into smaller, reviewable chunks. It moves several UI components from
packages/featurestoapps/web/modulesto support the vertical slice architecture and reduce circular dependencies.Components moved:
timezone-select→apps/web/modules/timezone/componentsTimezoneChangeDialog→apps/web/modules/settings/componentsWebPushContext→apps/web/modules/settings/my-account/componentsinsights/lib/types.ts→apps/web/modules/insights/lib/types.tsAll import paths across 29 files have been updated accordingly.
@calcom/features[3] #26571Mandatory Tasks (DO NOT REMOVE)