Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the new canonical ABI #201

Closed
17 of 21 tasks
alexcrichton opened this issue Apr 20, 2022 · 5 comments
Closed
17 of 21 tasks

Implement the new canonical ABI #201

alexcrichton opened this issue Apr 20, 2022 · 5 comments

Comments

@alexcrichton
Copy link
Member

alexcrichton commented Apr 20, 2022

I've started sending PRs to do this, but I figured it'd also be a good thing to write things down:

(I'll probably add to this over time as I remember things)

@alexcrichton
Copy link
Member Author

Ok I think all the major pieces that can be done now are largely done. The remaining bits sort of need questions and topics on #214 to be settled first. For example post-return-style things aren't done but functions aren't guaranteed to have a post-return so it doesn't make sense for the host generators to implement something with post-return as-is.

@alexcrichton
Copy link
Member Author

I'm going to close this in favor of #314 since the remaining few items here and there that need to be covered by hosts I think require deeper refactorings to fully address or they're inconsequential to not really matter a whole lot.

@dbaeumer
Copy link

dbaeumer commented Apr 22, 2024

@alexcrichton I have a question regarding (since all the 'favored' issues are closed):

Enable mutability in Rust traits generated for in-wasm since recursive entry is now prohibited

wit-bindgen version 0.24.0 still generates x(&self) signature in traits. Is this going to change in the future.

@alexcrichton
Copy link
Member Author

It can theoretically yeah but it would be a bit of a nontrivial lift. I didn't handle that during this whole transition due to the complexity involved, but I forgot to open another tracking issue. If you're up for it would you be ok opening a new issue for it?

@petehayes102
Copy link

Seems the issue wasn't raised? I've done that now because this is a painful restriction. Apologies if it's a dupe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants