Represent Variant with a non-optional payload type
#220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the internal representation of the `Variant` type to
have a non-optional payload type as well as no customizable `tag` type.
This brings the `Variant` type into alignment with the current canonical
ABI where the payload type is non-optional as well. The `*.wit` syntax
is not changing, however, where `variant { foo }` is sugar for
`variant { foo(unit) }`. Various code generators were tweaked as well to
get the new type representation to work as well.
21 tasks
peterhuene
approved these changes
May 9, 2022
willemneal
pushed a commit
to AhaLabs/wit-bindgen
that referenced
this pull request
May 31, 2022
…e#220) This commit updates the internal representation of the `Variant` type to have a non-optional payload type as well as no customizable `tag` type. This brings the `Variant` type into alignment with the current canonical ABI where the payload type is non-optional as well. The `*.wit` syntax is not changing, however, where `variant { foo }` is sugar for `variant { foo(unit) }`. Various code generators were tweaked as well to get the new type representation to work as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the internal representation of the
Varianttype tohave a non-optional payload type as well as no customizable
tagtype.This brings the
Varianttype into alignment with the current canonicalABI where the payload type is non-optional as well. The
*.witsyntaxis not changing, however, where
variant { foo }is sugar forvariant { foo(unit) }. Various code generators were tweaked as well toget the new type representation to work as well.