Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename f32/f64 to float32/float64 #198

Merged
merged 2 commits into from
Apr 20, 2022

Conversation

alexcrichton
Copy link
Member

This commit renames the previously-known f32 and f64 interface types
to float32 and float64 to match the upstream specification.

This commit renames the previously-known `f32` and `f64` interface types
to `float32` and `float64` to match the upstream specification.
Copy link
Member

@sunfishcode sunfishcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The name change also signals the introduction of NaN canonicalization, but we can add that separately.

@alexcrichton alexcrichton mentioned this pull request Apr 20, 2022
21 tasks
@alexcrichton
Copy link
Member Author

Good point! I'd actually forgotten that so I went ahead and made a checklist of known items at #201 -- let me know if I forgot something though

@alexcrichton alexcrichton merged commit 76b8a9a into bytecodealliance:main Apr 20, 2022
@alexcrichton alexcrichton deleted the rename-floats branch April 20, 2022 16:13
Michael-F-Bryan pushed a commit to hotg-ai/wit-files that referenced this pull request May 3, 2022
Michael-F-Bryan pushed a commit to hotg-ai/proc-blocks that referenced this pull request May 3, 2022
Michael-F-Bryan pushed a commit to hotg-ai/wit-files that referenced this pull request May 15, 2022
willemneal pushed a commit to AhaLabs/wit-bindgen that referenced this pull request May 31, 2022
* Rename f32/f64 to float32/float64

This commit renames the previously-known `f32` and `f64` interface types
to `float32` and `float64` to match the upstream specification.

* Fix a test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants