Initial work towards getting post-return functions #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
force-pushed
the
post-return
branch
from
050f13b
to
a1b2228
Compare
21 tasks
alexcrichton
force-pushed
the
post-return
branch
from
a1b2228
to
0f86462
Compare
This adds a few new pseudo-instructions plus a new method on `Interface`
to generate a `post-return` function. For now these are simply named
`{name}_post_return` and the integration point there will probably
change as the component model shapes up.
The integration here is intended to still be relatively primitive in
that the actual component model integration will likely look different
in the future. Given how `wit-bindgen` works today, though, this should
at least get things part of the way there.
alexcrichton
force-pushed
the
post-return
branch
from
0f86462
to
94c397e
Compare
pchickey
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a few new pseudo-instructions plus a new method on
Interfaceto generate apost-returnfunction. For now these are simply named{name}_post_returnand the integration point there will probably change as the component model shapes up.The integration here is intended to still be relatively primitive in that the actual component model integration will likely look different in the future. Given how
wit-bindgenworks today, though, this should at least get things part of the way there.