Merge main into dev/socket_api #1035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XNNPACK code base is updating quickly, we specify a commit ID for it so as to build XNNPACK workload successfully.
Add log info for heap and stack like wasm loader in aot loader Signed-off-by: Huang Qi <huangqi3@xiaomi.com> Change-Id: I349848d75f1a26cde29217c14cfb6e779c976a8b
Currently when calling wasm_runtime_call_wasm() to invoke wasm function with externref type argument from runtime embedder, developer needs to use wasm_externref_obj2ref() to convert externref obj into an internal ref index firstly, which is not convenient to developer. To align with GC feature in which all the references passed to wasm_runtime_call_wasm() can be object pointers directly, we change the interface of wasm_runtime_call_wasm() to allow to pass object pointer directly for the externref argument, and refactor the related codes, update the related samples and the document.
Refactor LLVM Orc JIT to actually enable the lazy compilation and speedup the launching process: https://llvm.org/docs/ORCv2.html#laziness Main modifications: - Create LLVM module for each wasm function, wrap it with thread safe module so that the modules can be compiled parallelly - Lookup function from aot module instance's func_ptrs but not directly call the function to decouple the module relationship - Compile the function when it is first called and hasn't been compiled - Create threads to pre-compile the WASM functions parallelly when loading - Set Lazy JIT as default, update document and build/test scripts
Use LLVM new pass manager for wamrc to replace the legacy pass manger, so as to gain better performance and reduce the compilation time. Reference links: - https://llvm.org/docs/NewPassManager.html - https://blog.llvm.org/posts/2021-03-26-the-new-pass-manager And add an option to use the legacy pm mode when building wamrc: cmake .. -DWAMR_BUILD_LLVM_LEGACY_PM=1 For JIT mode, keep it unchanged as it only runs several function passes and using new pass manager will increase the compilation time. And refactor the codes of applying LLVM passes.
Implement pthread_cond_broadcast wrapper for lib-pthread - support pthread_cond_broadcast wrapper for posix/linux-sgx/windows - update document for building multi-thread wasm app with emcc
Implement WAMR-IDE with vscode extension to enable developing WebAssembly applications with coding, building, running and debugging support. Support both Linux and Windows, and only support putting all the tools in a docker image, e.g. wasi-sdk, wamrc, iwasm and so on. Co-authored-by: Wang Ning <justdoitwn@163.com>
Add scripts to build and run benchmark of coremark, polybench, sightglass and jetstream2. And add documents.
Update README.md, add "Getting Started", “Performance and Footprint”, ”Use Cases", and refine some sections. Add memory tune document and fix wasm-c-api document.
Fix wamr-ide link error, set wamr-ide to experimental and fix README issues
And fix a double free issue when starting debug server failed
Improve riscv target option compatibility for NuttX Signed-off-by: Huang Qi <huangqi3@xiaomi.com> Change-Id: I100793e0f00e7e4929e295c4bb1ef1ec21d83fe9
RIOT-OS currently changes xtimer to ztimer
win_thread.c os_cond_wait_internal returns os_sem_reltimed_wait or os_sem_wait result instead of always return BHT_OK before
Fix attr container forward declaration issue reported in #996
Fix pthread_getspecific return value as mentioned in #995
Allow compilation on Windows MinGW, see build_wamr.md for more details. Note that WASI and some other smallish details are still not supported, but we have a starting point. See more discussion at #993
Change signature of riot `os_mmap` implementation to match declaration in core/shared/platform/include/platform_api_vmcore.h
Increase default/min native stack size when UVWASI is enabled as UVWASI requires larger native stack size. Increase the reserved bytes to the native thread stack boundary to better detect the native stack overflow. Set WASM_DISABLE_HW_BOUND_CHECK to 0 when interpreter is enabled and AOT is disabled, as memory access boundary check with hardware trap is only enabled in AOT/JIT mode.
Update document memory_tune.md: fix embed wamr link error, fix description error of wasm operand stack size, update picture. Fix wasm_runtime_call_wasm_a issue reported by #1003 and update sample basic to call this API.
The littlevgl library had changed its name and domain to [LVGL](https://lvgl.io). See https://blog.lvgl.io/2020-06-01/announcement We change some names and links accordingly. Also remove the cloning for tlsf library as it isn't used now.
When building JIT, interpreter must be enabled, we enabled interpreter explicitly in config_common.cmake if it is disabled.
Allow to set break point again when all break points are removed and wasm app starts running.
Add app_manager_is_started API per requested by #1004 to support checking the status of app manager in another thread.
In some Linux systems whose kernel version is smaller than 2.6.38, the macro MADV_HUGEPAGE isn't introduced yet which causes compilation error. Add macro control to fix the compilation error.
Use sysconfig.get_platform() to check whether the platform is MinGW, and link necessary libraries to wamrc on MinGW.
Signed-off-by: Huang Qi <huangqi3@xiaomi.com> > And another question, I got many warnings while compiling wamr by clang like: > > ``` > [10/67] Building C object CMakeFiles/vmlib.dir/home/huang/Work/wasm-micro-runtime/core/iwasm/common/wasm_exec_env.c.o > In file included from /home/huang/Work/wasm-micro-runtime/core/iwasm/common/wasm_exec_env.c:6: > In file included from /home/huang/Work/wasm-micro-runtime/core/iwasm/common/wasm_exec_env.h:11: > /home/huang/Work/wasm-micro-runtime/core/iwasm/common/../interpreter/wasm.h:573:53: warning: unused parameter 'type_count' [-Wunused-parameter] > wasm_get_smallest_type_idx(WASMType **types, uint32 type_count, > ^ > 1 warning generated. > [15/67] Building C object CMakeFiles/vmlib.dir/home/huang/Work/wasm-micro-runtime/core/iwasm/common/wasm_application.c.o > In file included from /home/huang/Work/wasm-micro-runtime/core/iwasm/common/wasm_application.c:8: > In file included from /home/huang/Work/wasm-micro-runtime/core/iwasm/common/../interpreter/wasm_runtime.h:9: > /home/huang/Work/wasm-micro-runtime/core/iwasm/interpreter/wasm.h:573:53: warning: unused parameter 'type_count' [-Wunused-parameter] > wasm_get_smallest_type_idx(WASMType **types, uint32 type_count, > ^ > 1 warning generated. > ``` > > It can be fixed simply by -Wno-unused-parameter, but should we fix it by `UNUSED(xxx)` manually ? It would be great to fix these warnings, but it really takes efforts.
When calling native function from AOT code, current implementation is to return back to runtime to call aot_invoke_native, which calls wasm_runtime_invoke_native and the latter calls assembly code. We did it before as there may be pointer and string arguments to check and convert if the native function's registered signature has character '*' and '$'. As the built-in native function's signatures can be gotten in compilation time, we check the pointer/string arguments and convert them into native address in AOT code, and then invoke the native function directly, so as to improve performance.
Fix several issues in wasm-c-api wasm_module_imports function:
1. Two of the if branches never set the module_name and name fields which are later passed as arguments to wasm_importtype_new, and eventually might cause double-free and/or use-after-free
2. Should zero module_name/name/extern_type at the start of loop iteration, and destroy their resources when failed at the end of loop iteration
2. No need to check `if (!extern_type) { continue; }`, as extern_type is converted from type and type is already checked
3. No need to wasm_importtype_vec_delete(out) when failed, as it is passed from outside and should be destroyed by outside
Update CI files: - add another apt repository for spec test on x86-32 as some packages cannot be downloaded with the Github default repository - trigger the CI file when it is modified
Since DPFPU depends on FPU, if FPU is enabled we will never enter DPFPU
branch since `ifeq (${CONFIG_ARCH_FPU}, y)` is always true.
Signed-off-by: Huang Qi <huangqi3@xiaomi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.