Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix native stack overflow check failed in interpreter #992

Merged
merged 3 commits into from
Feb 11, 2022
Merged

Fix native stack overflow check failed in interpreter #992

merged 3 commits into from
Feb 11, 2022

Conversation

wenyongh
Copy link
Contributor

No description provided.

@wenyongh wenyongh changed the title [WIP] Fix stack overflow check failed in interpreter [WIP] Fix native stack overflow check failed in interpreter Jan 29, 2022
@wenyongh wenyongh mentioned this pull request Jan 29, 2022
Closed
xingkaiyu
xingkaiyu reviewed Feb 2, 2022
View reviewed changes
Copy link
Contributor

@xingkaiyu xingkaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you forget to change the comment after #endif in core/shared/platform/vxworks/platform_internal.h

@wenyongh wenyongh changed the title [WIP] Fix native stack overflow check failed in interpreter Fix native stack overflow check failed in interpreter Feb 10, 2022
@wenyongh
Copy link
Contributor Author

I think you forget to change the comment after #endif in core/shared/platform/vxworks/platform_internal.h

Updated and tried not to modify the platform related files, could you please test again? Thanks.

@wenyongh wenyongh merged commit 59282f7 into bytecodealliance:main Feb 11, 2022
@wenyongh wenyongh deleted the fix_uvwasi_soe branch February 13, 2022 07:49
xujuntwt95329 pushed a commit to xujuntwt95329/wasm-micro-runtime that referenced this pull request Mar 13, 2022
@wenyongh @xujuntwt95329
Fix native stack overflow check failed in interpreter (bytecodeallian…
8e7e086 
…ce#992)

Increase default/min native stack size when UVWASI is enabled as
UVWASI requires larger native stack size.
Increase the reserved bytes to the native thread stack boundary to
better detect the native stack overflow.
Set WASM_DISABLE_HW_BOUND_CHECK to 0 when interpreter is
enabled and AOT is disabled, as memory access boundary check
with hardware trap is only enabled in AOT/JIT mode.
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
@wenyongh
Fix native stack overflow check failed in interpreter (bytecodeallian…
6e7a0f6 
…ce#992)

Increase default/min native stack size when UVWASI is enabled as
UVWASI requires larger native stack size.
Increase the reserved bytes to the native thread stack boundary to
better detect the native stack overflow.
Set WASM_DISABLE_HW_BOUND_CHECK to 0 when interpreter is
enabled and AOT is disabled, as memory access boundary check
with hardware trap is only enabled in AOT/JIT mode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xingkaiyu xingkaiyu xingkaiyu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wenyongh @xingkaiyu