Skip to content

Add source debug vscode extension #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 24, 2022
Merged

Add source debug vscode extension #943

merged 2 commits into from
Jan 24, 2022

Conversation

@wustwn
Copy link
Contributor

@wustwn wustwn commented Jan 8, 2022

No description provided.

@wustwn wustwn force-pushed the vscode-extension branch 4 times, most recently from 494a41c to 52e652b Compare January 10, 2022 08:53
wenyongh
wenyongh reviewed Jan 11, 2022
View reviewed changes
test-tools/wamr-ide/README.md Outdated

- `VSCode extension` is an extension which can be installed in `vscode`, with which user can build and manage projects, develop `wasm application`, including `building`, `running` and `debugging`.

- `WASM-toolchain-provider` is a docker image that provide building environment for wasm.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which provides building environment for wasm application

test-tools/wamr-ide/README.md Outdated

---

## How to setup WAMR IDE from zero
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about How to setup WAMR IDE?

test-tools/wamr-ide/WASM-Source-Debug-Server/Docker/README.md Outdated
@@ -0,0 +1,16 @@
### Build Docker Image

- execute `build_docker_image.bat` on `Windows`, note that change the `./resource/run.sh` and `./resource/debug.sh` to `LF` before building
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we provide run.bat and debug.bat for Windows, and let build_docker_image.bat invoke them? It is inconvenient for use to change the file content

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run.sh and debug.sh will be executed inside of WASM source debug server image rather than in host, so we don't need to provide the batch script for windows. Besides, change the End of Line Sequence to LF is just necessary when user want to build image on windows platform

test-tools/wamr-ide/WASM-Source-Debug-Server/Docker/README.md Outdated
### Resource Details

- `Dockerflie` is the source file to build `wasm-debug-server` docker image
- `resource/debug.sh` is the script to execute the `/mnt/build/${target}.wasm` in debug mod, will start up the debugger server inside of the `iwasm` and hold to wait for connecting.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debug mode

test-tools/wamr-ide/WASM-Toolchain-Provider/Docker/README.md Outdated
@@ -0,0 +1,76 @@
# Intro
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "WASM Toolchain Provider Introduction"?

test-tools/wamr-ide/WASM-Toolchain-Provider/Docker/README.md Outdated
```

- Windows
> Note that change the `./resource/build_wasm.sh` to `LF` before building
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If build_wasm.bat is created, no need to change it

wenyongh
wenyongh reviewed Jan 11, 2022
View reviewed changes
Copy link
Contributor

@wenyongh wenyongh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some pictures, will them be very big so the repo size increases a lot?

@wustwn wustwn force-pushed the vscode-extension branch 2 times, most recently from a24e21a to 6a6b183 Compare January 13, 2022 09:37
wenyongh
wenyongh reviewed Jan 14, 2022
View reviewed changes
test-tools/wamr-ide/README.md Outdated

![set_up_workspace_message](./Media/set_up_workspace_message.png "set up workspace message box")

You can click `Set up now` and select the target folder to create project workspace, or you click `Maybe later` to close the message box.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"or you click" => "click"?

test-tools/wamr-ide/VSCode-Extension/README.md

# How to debug this extension

> Note that please build `lldb` firstly follow this
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

follow => following?

test-tools/wamr-ide/README.md Outdated

1. Install `VSCode` on host.

- make sure the version of [vscode](https://code.visualstudio.com/Download) you install >_1.59.0_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about you installed is at least _1.59.0_

test-tools/wamr-ide/WASM-Source-Debug-Server/Docker/README.md Outdated
@@ -0,0 +1,16 @@
### Build Docker Image

- execute `build_docker_image.bat` on `Windows`, note that change the `./resource/run.sh` and `./resource/debug.sh` to `LF` before building
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we forget to change the document? The .sh files had been changed to LF?

@wustwn wustwn force-pushed the vscode-extension branch 4 times, most recently from 8d81cdd to 845e02e Compare January 15, 2022 15:44
xujuntwt95329
xujuntwt95329 reviewed Jan 17, 2022
View reviewed changes
.gitignore Outdated

build_out
tests/wamr-test-suites/workspace

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this file has been changed to CRLF style, could you re-save it as LF?

xujuntwt95329
xujuntwt95329 reviewed Jan 17, 2022
View reviewed changes
@wustwn wustwn force-pushed the vscode-extension branch 2 times, most recently from be4a6a3 to 0a36768 Compare January 18, 2022 12:36
@wenyongh wenyongh merged commit 9a85af7 into bytecodealliance:dev/source_debug_vscode Jan 24, 2022
wenyongh added a commit that referenced this pull request Jan 25, 2022
@wenyongh @wustwn
Implement WAMR-IDE with vscode extension (#943)
d925369 
Implement WAMR-IDE with vscode extension to enable developing
WebAssembly applications with coding, building, running and
debugging support. Support both Linux and Windows, and only
support putting all the tools in a docker image, e.g. wasi-sdk, wamrc,
iwasm and so on.

Co-authored-by: Wang Ning <justdoitwn@163.com>
vickiegpt pushed a commit to vickiegpt/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
@wenyongh @wustwn
Implement WAMR-IDE with vscode extension (bytecodealliance#943)
70e8eee 
Implement WAMR-IDE with vscode extension to enable developing
WebAssembly applications with coding, building, running and
debugging support. Support both Linux and Windows, and only
support putting all the tools in a docker image, e.g. wasi-sdk, wamrc,
iwasm and so on.

Co-authored-by: Wang Ning <justdoitwn@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xujuntwt95329 xujuntwt95329 xujuntwt95329 left review comments

@wenyongh wenyongh wenyongh left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wustwn @xujuntwt95329 @wenyongh