fix debug thread not create issue #983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenyongh
reviewed
Jan 25, 2022
| may cause exception thrown. */ | ||
| if ((func = wasm_runtime_lookup_wasi_start_function(module_inst))) { | ||
| #if WASM_ENABLE_DEBUG_INTERP != 0 | ||
| wasm_runtime_start_debug_instance(exec_env); |
There was a problem hiding this comment.
Should check the return value?
There was a problem hiding this comment.
And after the following wasm_runtime_call_wasm, shall we destroy the debug instance?
There was a problem hiding this comment.
This API return the actual bind port number, or 0 if the debug instance not created. We don't check the return value here, because when user execute iwasm w/o -g={ip}:{port}, the API will return 0, but we still want the program to be executed
There was a problem hiding this comment.
And after the following wasm_runtime_call_wasm, shall we destroy the debug instance?
We don't need to destroy the debug instance, it will be automatically destroyed when the corresponding cluster is destroyed.
| } | ||
|
|
||
| #if WASM_ENABLE_DEBUG_INTERP != 0 | ||
| wasm_runtime_start_debug_instance(exec_env); |
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
And fix a double free issue when starting debug server failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And fix a double free issue when starting debug server failed