Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyFormatter - boost::function to std::function #735

Merged
merged 2 commits into from
Apr 8, 2021

Conversation

varunagrawal
Copy link
Collaborator

This PR updates the KeyFormatter typedef from boost::function to std::function.

@gchenfc and I discovered that the pybind11 wrapper plays well with std::function but not with boost::function. So this change will enable the direct use of gtsam::KeyFormatter in the wrapped code without any major modifications or hacks.

The best part is that std::function is a drop-in replacement to boost::function for this particular use case, so there should be no breaking change.

@varunagrawal varunagrawal added the feature New proposed feature label Apr 7, 2021
@varunagrawal varunagrawal self-assigned this Apr 7, 2021
Copy link
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modulo comment

gtsam/inference/Key.h Show resolved Hide resolved
@gchenfc gchenfc merged commit 58cc7b8 into develop Apr 8, 2021
@gchenfc gchenfc deleted the feature/std-keyformatter branch April 8, 2021 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New proposed feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants