Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove logmap function from LieVector and LieMatrix #538

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Remove logmap function from LieVector and LieMatrix #538

merged 1 commit into from
Sep 24, 2020

Conversation

varunagrawal
Copy link
Collaborator

Fixes regression introduced in #532.

@varunagrawal varunagrawal added bugfix Fixes an issue or bug quick-review Quick and easy PR to review high-priority Need this done quickly easy-fix Quick and easy to fix labels Sep 22, 2020
@varunagrawal varunagrawal self-assigned this Sep 22, 2020
ayushbaid
ayushbaid approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@ayushbaid ayushbaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Simple change reverting the function addition

@varunagrawal varunagrawal merged commit c7936cd into develop Sep 24, 2020
@varunagrawal varunagrawal deleted the fix/matlab-logmap branch September 24, 2020 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dellaert dellaert dellaert approved these changes

@ayushbaid ayushbaid ayushbaid approved these changes

Assignees

@varunagrawal varunagrawal

Labels
bugfix Fixes an issue or bug easy-fix Quick and easy to fix high-priority Need this done quickly quick-review Quick and easy PR to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@varunagrawal @ayushbaid @dellaert