This repository has been archived by the owner on Jun 17, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dep on node 14.18 will get cleaned up once we bump electron
This was referenced Dec 10, 2021
mimartin12
previously approved these changes
Dec 10, 2021
Hinton
reviewed
Dec 13, 2021
.github/workflows/build.yml
Outdated
|
||
- name: Update NPM | ||
run: | | ||
npm install -g npm@7 | ||
npm install -g npm@8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need this? We might be able to remove this whole block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Hinton: Tested this on a separate branch and it builds fine. Removed it.
npm v8.1.2 is included in node v16
Hinton
approved these changes
Dec 13, 2021
9 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
With our plan to bump electron soon, we need to upgrade Node to v16 (LTS) as newer version of electron require it. Also not a bad idea to move to the newest LTS.
Code changes
npm i
Testing requirements
All unit test still green.
Regression testing will be needed on the clients once those are updated
Before you submit
npm run lint
) (required)