Skip to content
This repository has been archived by the owner on Jun 17, 2022. It is now read-only.

Bump node to 16 and npm #575

Merged
merged 7 commits into from
Dec 13, 2021
Merged

Bump node to 16 and npm #575

merged 7 commits into from
Dec 13, 2021

Conversation

djsmith85
Copy link
Contributor

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

With our plan to bump electron soon, we need to upgrade Node to v16 (LTS) as newer version of electron require it. Also not a bad idea to move to the newest LTS.

Code changes

  • package.json: Updated engine requirements and bumped @types/node to 16.11.12
  • common/package.json: Bump @types/node to 16.11.12
  • electron/package.json: Bump @types/node to 16.11.12
  • node/package.json: Bump @types/node to 16.11.12
  • build.yml: Setting the build to require node v16 and npm v8
  • README.md: Updated requirements
  • Various package-lock.json: Updates after running npm i

Testing requirements

All unit test still green.
Regression testing will be needed on the clients once those are updated

Before you submit

  • I have checked for linting errors (npm run lint) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

mimartin12
mimartin12 previously approved these changes Dec 10, 2021
@djsmith85 djsmith85 requested a review from a team December 10, 2021 15:33

- name: Update NPM
run: |
npm install -g npm@7
npm install -g npm@8
Copy link
Member

@Hinton Hinton Dec 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this? We might be able to remove this whole block.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hinton: Tested this on a separate branch and it builds fine. Removed it.

@djsmith85 djsmith85 merged commit 8fc3cf5 into master Dec 13, 2021
@djsmith85 djsmith85 deleted the bump-node-to-16 branch December 13, 2021 10:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants