Skip to content
This repository has been archived by the owner on Jun 17, 2022. It is now read-only.

Bump node to 16 and npm #575

Merged
merged 7 commits into from
Dec 13, 2021
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Modify build.yml to build with node 16 and npm 8
  • Loading branch information
djsmith85 committed Dec 10, 2021
commit a3698147a39ef2f5fe5e45e4988a20eef59772af
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,11 @@ jobs:
- name: Set up Node
uses: actions/setup-node@46071b5c7a2e0c34e49c3cb8a0e792e86e18d5ea
with:
node-version: '14'
node-version: '16'

- name: Update NPM
run: |
npm install -g npm@7
npm install -g npm@8
Copy link
Member

@Hinton Hinton Dec 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this? We might be able to remove this whole block.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hinton: Tested this on a separate branch and it builds fine. Removed it.

npm install -g node-gyp
node-gyp install $(node -v)

Expand Down