Skip to content
This repository has been archived by the owner on Jul 23, 2022. It is now read-only.

Bump node to v16 #1189

Merged
merged 8 commits into from
Dec 13, 2021
Merged

Bump node to v16 #1189

merged 8 commits into from
Dec 13, 2021

Conversation

djsmith85
Copy link
Contributor

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

With our plan to bump electron soon, we need to upgrade Node to v16 (LTS) as newer version of electron require it.

Depends on bitwarden/jslib#575
Asana task: https://app.asana.com/0/1200804338582616/1201498644188828/f

Code changes

  • jslib: Bump jslib from Bump node to 16 and npm  jslib#575
  • .nvmrc: Set it require to node 16.13.1
  • package.json: Updated engine requirements and bumped @types/node to 16.11.12
  • package-lock.json: Updates after running npm i
  • build.yml: Setting the build to require node v16 and npm v8
  • README.md: Updated requirements

Testing requirements

Will require running regression testing.

Before you submit

  • I have checked for linting errors (npm run lint) (required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

@djsmith85 djsmith85 requested a review from a team December 10, 2021 13:04
mimartin12
mimartin12 previously approved these changes Dec 10, 2021
@djsmith85 djsmith85 requested a review from a team December 10, 2021 15:41
@djsmith85 djsmith85 merged commit 5865f08 into master Dec 13, 2021
@djsmith85 djsmith85 deleted the bump-node-to-v16 branch December 13, 2021 16:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants