Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump node to v16 #187

Merged
merged 14 commits into from
Dec 10, 2021
Merged

Bump node to v16 #187

merged 14 commits into from
Dec 10, 2021

Conversation

djsmith85
Copy link
Contributor

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

With our plan to bump electron soon, we need to upgrade Node to v16 (LTS) as newer version of electron require it.

Depends on bitwarden/jslib#575
Asana task: https://app.asana.com/0/1200804338582616/1201498644188831/f

Code changes

  • jslib: Bump jslib from Bump node to 16 and npm  jslib#575
  • package.json: Updated engine requirements and bumped @types/node to 16.11.12, bump keytar to v7.7.0
  • package-lock.json: Updates after running npm i
  • src/package.json: bump keytar to v7.7.0
  • src/package-lock.json: Was missing
  • src-cli/package.json: bump keytar to v7.7.0
  • src-cli/package-lock.json: Was missing
  • build.yml: Setting the build to require node v16 and npm v8,
  • README.md: Updated requirements

Testing requirements

Will require running regression testing.

Before you submit

  • I have checked for linting errors (npm run lint) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

@djsmith85 djsmith85 marked this pull request as ready for review December 10, 2021 18:42
@djsmith85 djsmith85 requested a review from a team December 10, 2021 18:42
@djsmith85 djsmith85 requested a review from a team December 10, 2021 19:50
@djsmith85 djsmith85 merged commit 6b98a46 into master Dec 10, 2021
@djsmith85 djsmith85 deleted the bump-node-to-v16 branch December 10, 2021 20:08
@djsmith85 djsmith85 mentioned this pull request Dec 13, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants