This repository was archived by the owner on Jun 17, 2022. It is now read-only.
Set up API calls for bulk delete from within an org vault #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
July 10, 2020 15:18
|
|
…owMultiSelectInOrgVault Grabbing latest
kspearrin
reviewed
Jul 22, 2020
| } | ||
|
|
||
| getSelectedIds(): string[] { | ||
| return this.getSelected().map((c) => c.id); |
There was a problem hiding this comment.
I dont think this needs to be in jslib since it still only applies to the web vault. the org ciphers componenet already inherits from the regular ciphers component where this lives in the web repo so it should be reusable already.
* Initial work on windows hello support * Switch to use windows.security.credentials.ui UserConsentVerifier * Fix linting warnings * Remove unessesary supportsBiometric from lock screen * Rename biometric.main to windows.biometric.main. Add abstraction for biometric. * Add support for dynamic biometric text. * Add untested darwin implementation * Rename fingerprintUnlock to biometric * Add new functions to cliPlatformUtils.service.ts. * Hide login if biometric is not supported * Export default for biometric.*.main.ts * Remove @nodert-win10-rs4/windows.security.credentials * Add build requirements to readme * Auto prompt biometric when starting the application. * Ensure we support biometric before trying to auto prompt. * Fix review comments and linting errors
* [SSO] Reset Master Password (#134) * Initial commit of reset master password (sso) * Updated line length error * Updated import line again * Added trailing comma * restored reference data for RegisterRequest * Updated tracking boolean name // added success route update based on passed boolean * Added new API // reverted Register // deleted reset // added change pw and sso * Changed redirect URI to protected to override in sub-class * Updated api to setPassword // Updated request model name // Updated change password refs // Updated formatting * Encoded necessary parts of authorize url // Added default catch error message * Refactored methods inside change password base component // removed unnecesary query param for sso * [lint] Fixed error (#137) * Cleaned lint error * Fixed sso lint error
…ire-nodert try catch nodeRT module via require
* sso * move break into try block * make client id dynamic * clientId is a string, DOH! * reject if port not available * lint fixes
addisonbeck
changed the title
added 13 commits
August 3, 2020 22:24
…github.com/bitwarden/jslib into Feature.Web.534.AllowMultiSelectInOrgVault
cscharf
approved these changes
Aug 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Create necessary API calls for bulk deleting ciphers from an org vault
Code Changes
Created relevant requests
Related Issues
Relates to bitwarden/web #534
bitwarden/web PR #577 depends on this change