This repository was archived by the owner on Jun 17, 2022. It is now read-only.
try catch nodeRT module via require #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix bitwarden/desktop#495 by lazy-loading the offending module inside a
try {} catch {}instead of usingimport. This should prevent an app crash as well as mark anisErrorflag on the biometric module so the UI can display a message as to why it's not available (i.e. not supported on machine or need dependency, etc.)@kspearrin , I have been unable to test this, I can't get it build in my Windows VM and since I'm using macOS natively my build can't compile native Windows applications so I'm not able to test.
Can you please pull this draft PR and attempt a build/check. If it actually loads and Windows Hello still works, can you also please post it to 495 linked above for the user-community to test with as well (I also believe Luc can reproduce the issue so he'd also be able to test).