Feature.web.534.allow multi select in org vault #830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
July 17, 2020 13:58
…github.com/bitwarden/server into Feature.Web.534.AllowMultiSelectInOrgVault
cscharf
suggested changes
Jul 20, 2020
There was a problem hiding this comment.
You will also need to create a script file for the DB update in util/Migrator/DbScripts following the convention there to drop + create the new stored procedure. This script is used when deploying the server AND as a schema update script for self-hosted instances upon update.
|
Added migration script |
kspearrin
requested changes
Jul 20, 2020
kspearrin
requested changes
Jul 21, 2020
added 4 commits
July 21, 2020 12:04
…owMultiSelectInOrgVault
…wMultiSelectInOrgVault
|
|
kspearrin
requested changes
Jul 21, 2020
kspearrin
reviewed
Jul 22, 2020
kspearrin
previously approved these changes
Jul 22, 2020
added 2 commits
July 22, 2020 09:46
…owMultiSelectInOrgVault merge with latest
kspearrin
approved these changes
Jul 22, 2020
cscharf
approved these changes
Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Set up delete many w/admin methods for bulk deleting ciphers from within an org vault
Code Changes
Created relevant API methods and a stored procedure for implementing the objective
Related Issues
Relates to bitwarden/web #534
bitwarden/jslib PR #130 depends on this change