This repository was archived by the owner on Jun 17, 2022. It is now read-only.
SSO login for generic clients and CLI #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kspearrin
commented
Aug 3, 2020
kspearrin
commented
- Support SSO option when invoking the login command
- Support for other clients to call into SSO component ans pass parameters
cscharf
reviewed
Aug 3, 2020
kspearrin
commented
Aug 3, 2020
cscharf
approved these changes
Aug 3, 2020
cscharf
suggested changes
Aug 3, 2020
src/cli/commands/login.command.ts
Outdated
| callbackServer.close(() => reject()); | ||
| } | ||
| }); | ||
| let foundPort = false;; |
There was a problem hiding this comment.
ERROR: src/cli/commands/login.command.ts:237:35 - Unnecessary semicolon
ERROR: src/cli/commands/login.command.ts:237:35 - missing whitespace
cscharf
approved these changes
Aug 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.