-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Allow many_buttons
to be run without text
#8116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than rely on features, several other Very simple flag like in bevy/examples/stress_tests/many_cubes.rs Lines 52 to 53 in 52b91ac
|
I see, yes that's much simpler with commandline params. Changed it. |
many_buttons
to run without bevy_text
many_buttons
to run with no text
many_buttons
to run with no textmany_buttons
to be run without text
mockersf
approved these changes
Mar 17, 2023
james7132
requested changes
Mar 17, 2023
james7132
approved these changes
Mar 18, 2023
mockersf
approved these changes
Mar 18, 2023
ProfLander
pushed a commit
to shfty-rust/bevy
that referenced
this pull request
Mar 19, 2023
ProfLander
pushed a commit
to shfty-rust/bevy
that referenced
this pull request
Mar 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-UI
Graphical user interfaces, styles, layouts, and widgets
C-Examples
An addition or correction to our examples
C-Performance
A change motivated by improving speed, memory usage or compile times
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
many_buttons
isn't a good benchmark in all cases because it draws so much text. Allowmany_buttons
to be run without text.Solution
If the command-line flag
no-text
is specified, don't draw any text.Changelog
many_buttons
can now be run without text. To start without text run:cargo run --example many_buttons --release no-text