-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Initial tonemapping options #7594
Closed
Closed
Changes from 1 commit
Commits
Show all changes
88 commits
Select commit
Hold shift + click to select a range
b50ab5e
setup initial tonemapping options
DGriffin91 12c1d45
exr support, more tonemapping, initial test scene
DGriffin91 a716ef8
add AgX
DGriffin91 5284938
improve test scene, make methods selectable
DGriffin91 7300d3e
improve test scenes
DGriffin91 e77346a
disable grading, fix exmaple test patterns
DGriffin91 74a8eaf
update example descriptions, tweak settings
DGriffin91 cd2234b
add blender filmic
DGriffin91 68a333e
use include_bytes for luts image
DGriffin91 0c3bf82
make tonemapping work in main pass and sprites
DGriffin91 95ad250
use 3d LUTs
DGriffin91 3c6b223
remove bindings from sprite/mesh2d, make tonemapping work in custom t…
DGriffin91 b628e9a
remove tonemapping bindings from sprite wgsl
DGriffin91 bf3a340
add basic color grading controls
DGriffin91 8edb5c2
fix ci stuff, clean up tonemapping code
DGriffin91 69b3efa
Merge remote-tracking branch 'origin' into tonemap_options
DGriffin91 d6cf573
merge in main
DGriffin91 a63ae5a
improve tonemapping example
DGriffin91 bdb52c8
update sbdt2
DGriffin91 7cd3a38
misc nits
DGriffin91 a3405c1
use exr for sbdt2 for now
DGriffin91 c6dbd4a
remove pr 7564 task pool stuff
DGriffin91 4535489
use ktx2 for luts, update naming
DGriffin91 16904fe
remove exr from default features
DGriffin91 6630c15
WIP tonemapping example refactor
JMS55 dad817f
update ACES to base implementation without white parameter
DGriffin91 bfa26d9
More WIP tonemap example
JMS55 53c810b
Add reset color grading
JMS55 7b6e43f
Add back matched color grading
JMS55 3866632
Rename ACES
JMS55 3d9bebf
Update crates/bevy_core_pipeline/src/tonemapping/mod.rs
JMS55 2488305
Merge pull request #1 from JMS55/tonemap_options
DGriffin91 fd85e9d
Revert "Tonemapping example refactor "
DGriffin91 291ce1f
Merge pull request #2 from DGriffin91/revert-1-tonemap_options
DGriffin91 afe9ad5
Fix bug
JMS55 1dac246
Fix bugfix
JMS55 f128b53
Add reset to scene default vs regular default
JMS55 7890cc4
Fix mixmatched keys
JMS55 314bf50
Save color grading per method
JMS55 0f14b42
Chnage controls
JMS55 e07121d
Merge branch 'tonemap_options' into tonemap_options
DGriffin91 315379b
Merge pull request #4 from JMS55/tonemap_options
DGriffin91 79b5e19
tweak example
DGriffin91 de00f72
move around entities
DGriffin91 60b3281
remove TonemappingMethod, make Dither separate Component
DGriffin91 2011fca
fix crash on arrow up, bring back hide option
DGriffin91 964cf81
build-example-pages
DGriffin91 f7b8a94
fix sprite/mesh2d
DGriffin91 510fda5
improve hide ui ui
DGriffin91 51c028c
fix ci/clippy errors
DGriffin91 77f1c28
Merge remote-tracking branch 'origin/main' into tonemap_options
DGriffin91 cf27b91
improve texture sample exclusion logic
DGriffin91 e461f83
fix color sweep shader
DGriffin91 6ebc9aa
remove old godot aces code
DGriffin91 959748d
update tony_mc_mapface file and attribution
DGriffin91 5a46cb0
add info for creating luts
DGriffin91 feabb2a
use ACES Fitted name everywhere
DGriffin91 d9780d2
add docstring for debanding dither
DGriffin91 2b2a1bb
Merge branch 'tonemap_options' of https://github.com/DGriffin91/bevy …
DGriffin91 6412a32
rename Dither component to DebandDither
DGriffin91 51695a4
remove rgb_to_srgb_simple
DGriffin91 5e2846f
use tone_mapping for sprite
DGriffin91 d8a30ac
use tone_mapping for mesh2d and color material
DGriffin91 c06fc0b
capitalize Tonemapping in Cargo.toml
DGriffin91 66cb51b
reuse cube mesh
DGriffin91 43dad10
ColorGrading definitions
DGriffin91 2053b6a
Tonemapping descriptions
DGriffin91 25d0d68
update tonemapping descriptions
DGriffin91 4cbbe25
fix color sweep x offset and add description
DGriffin91 8acf28b
description for continuous_hue
DGriffin91 a26b71d
update SomewhatBoringDisplayTransform description
DGriffin91 647436a
fix dithering nan issue
DGriffin91 b3a260d
Reset all with space/enter
DGriffin91 ff38ae7
automatic links for doc check
DGriffin91 173d3e9
component definitions
DGriffin91 a354928
TonemappingLuts doc string
DGriffin91 d0e891e
PipelineKey spacing
DGriffin91 c336932
ColorGrading doc string
DGriffin91 2cef295
fix ifdef spacing
DGriffin91 86e3e09
revert pi precision
DGriffin91 2530b0c
tonemapping doc string
DGriffin91 1507b7d
ImageFormat::Exr -> ImageFormat::OpenExr
DGriffin91 819e768
use full path for camera doc
DGriffin91 ec8355f
make including luts a default feature
DGriffin91 cfd37da
keep detection of tonemapping change on the node
DGriffin91 2b342e9
Update crates/bevy_core_pipeline/src/tonemapping/mod.rs
DGriffin91 abf5056
Update crates/bevy_core_pipeline/src/tonemapping/tonemapping_shared.wgsl
DGriffin91 d50e9be
Apply suggestions from code review
DGriffin91 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
update tony_mc_mapface file and attribution
- Loading branch information
commit 959748d51ef781c7f087584845e5596f1472447c
There are no files selected for viewing
Binary file not shown.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still feel like I want to say this is from Kajiya 0.1. :)