Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Use a fixed state hasher in bevy_reflect for deterministic Reflect::reflect_hash() across processes #7583

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - Use a fixed state hasher in bevy_reflect for deterministic Reflect::reflect_hash() across processes #7583

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
04f1ebb
Add bevy_reflect/fixed_hash for deterministic Reflect::reflect_hash()
johanhelsing Feb 9, 2023
9b48dfd
Always use a fixed hash for bevy_reflect
johanhelsing Feb 10, 2023
03f96d2
Move reflect_hasher to bevy_reflect::utility
johanhelsing Feb 14, 2023
d4475d1
Add doc comment for bevy_reflect::utility::reflect_hasher
johanhelsing Feb 14, 2023
9ce4f42
Merge main into fixed-reflect-hash
johanhelsing Feb 14, 2023
6dc4bc8
Fix doc link
johanhelsing Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add doc comment for bevy_reflect::utility::reflect_hasher
  • Loading branch information
@johanhelsing
johanhelsing committed Feb 14, 2023
commit d4475d1676d259ec445b47ce57083becf19ff149
5 changes: 5 additions & 0 deletions crates/bevy_reflect/src/utility.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,11 @@ impl GenericTypeInfoCell {
}
}

/// Deterministic fixed state hasher to be used by implementors of [`Reflect::reflect_hash`].
///
/// Hashes should be deterministic across processes so hashes can be used as
/// checksums for saved scenes, rollback snapshots etc. This function returns
/// such a hasher.
#[inline]
pub fn reflect_hasher() -> bevy_utils::AHasher {
FixedState.build_hasher()
Expand Down