[Merged by Bors] - Added buffer usage field to buffers #7423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Welcome, new contributor! |
kurtkuehnert
suggested changes
Jan 30, 2023
Contributor
kurtkuehnert
left a comment
kurtkuehnert
left a comment
There was a problem hiding this comment.
A nice first PR, thank you!
I think the buffer should be recreated, whenever the usage changes.
Besides the minor nit, this looks good to me.
kurtkuehnert
added
C-Feature
Contributor
|
Welcome, new contributor! |
kurtkuehnert
approved these changes
Jan 30, 2023
tim-blackbird
approved these changes
Jan 31, 2023
james7132
added
the
S-Ready-For-Final-Review
james7132
requested changes
Feb 4, 2023
superdump
requested changes
Feb 4, 2023
Member
|
bors try @superdump or @james7132 when you're ready, feel free to merge this. I don't understand buffers well enough to feel confident merging this myself. |
Contributor
tryBuild failed: |
Member
|
@SpeedRoll can you fix the CI errors listed in the output above so this becomes mergeable? |
Contributor
Author
|
@alice-i-cecile fixed |
james7132
requested changes
Feb 6, 2023
james7132
approved these changes
Feb 6, 2023
Member
|
bors try |
Contributor
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 6, 2023
# Objective Buffers in bevy do not allow for setting buffer usage flags which can be useful for setting COPY_SRC, MAP_READ, MAP_WRITE, which allows for buffers to be copied from gpu to cpu for inspection. ## Solution Add buffer_usage field to buffers and a set_usage function to set them
Contributor
|
Build failed: |
Member
|
Ubuntu mirrors please... bors retry |
bors bot
pushed a commit
that referenced
this pull request
Feb 6, 2023
# Objective Buffers in bevy do not allow for setting buffer usage flags which can be useful for setting COPY_SRC, MAP_READ, MAP_WRITE, which allows for buffers to be copied from gpu to cpu for inspection. ## Solution Add buffer_usage field to buffers and a set_usage function to set them
Contributor
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
Feb 6, 2023
# Objective Buffers in bevy do not allow for setting buffer usage flags which can be useful for setting COPY_SRC, MAP_READ, MAP_WRITE, which allows for buffers to be copied from gpu to cpu for inspection. ## Solution Add buffer_usage field to buffers and a set_usage function to set them
Contributor
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Buffers in bevy do not allow for setting buffer usage flags which can be useful for setting COPY_SRC, MAP_READ, MAP_WRITE, which allows for buffers to be copied from gpu to cpu for inspection.
Solution
Add buffer_usage field to buffers and a set_usage function to set them