-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Screen Space Ambient Occlusion (SSAO) MVP #7402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
480 commits
Select commit
Hold shift + click to select a range
134b27c
clean up pbr_prepass
IceSentry 2b0f4f9
Apply suggestions from code review
IceSentry c157cae
Extract constants
JMS55 b6acf22
Remove newline
JMS55 715ca65
fix unwrap on empty frag shader in prepass
IceSentry 35093ed
docs
IceSentry 5c9bb20
Merge commit '35093ed2e81b737fadfa5b50c32a6e49245acdf0' into gtao
JMS55 826b19a
Fix merge
JMS55 d95cc01
Merge branch 'main' into depth-prepass
IceSentry 8e1ffbc
Merge branch 'main' into depth-prepass
IceSentry d64286f
update to main
IceSentry c9159a5
add alpha_mask_phase items is_empty check
IceSentry c99f582
shorten comment
IceSentry 27db3b8
fix ci
IceSentry 060c52d
WIP FSR2 plugin
JMS55 14efad2
Further plugin setup
JMS55 fdbb4d2
Merge branch 'main' into depth-prepass
IceSentry a5ec2f5
Merge branch 'main' into depth-prepass
IceSentry 0af0d67
Merge remote-tracking branch 'icesentry/depth-prepass' into gtao
JMS55 a3e5c1b
Fix merge
JMS55 77ca0c8
WIP: FSR2Plugin
JMS55 8f5fda4
FSR2 jitter (breaks TAA for now)
JMS55 1bb796f
Fix shader ifdefs
JMS55 63003f7
Extract projection
JMS55 0b757e0
Misc
JMS55 f48bb83
Fix dep path
JMS55 1d48c29
Add neccesary texture usages
JMS55 3d5c81c
Misc
JMS55 ff68974
Add device field
JMS55 e9942d7
Cleanup jitter
JMS55 0e38fb4
Error checking
JMS55 b35586f
Store device in context
JMS55 cada547
WIP: Update TAA impl
JMS55 88112be
Fixes
JMS55 2cc10d5
Move TAA to core pipeline
JMS55 bc87f4c
Merge commit 'cab065bad4302e4df427ffbafcdb112e755321ce' into taa-only
JMS55 bf89ceb
Misc
JMS55 a545e2a
Merge fixes
JMS55 c44c33a
Documentation
JMS55 1ddfa48
Misc formatting
JMS55 e76cd0e
Appease clippy
JMS55 bf36eb0
Add plugin note to docs
JMS55 6b90c2c
Clippy is not yet appeased
JMS55 a1ca8db
Fix prepass vertex shader ifdefs
JMS55 742d0a1
Doc improvements
JMS55 e3f6a7e
Extract temporal jitter elsewhere
JMS55 f894e83
Merge commit '02637b609e8c9371e8f8b54deae5ee8594fb76c1' into taa-only
JMS55 0ae10d6
Fix merge
JMS55 bc5574c
Update crates/bevy_render/src/camera/camera.rs
JMS55 dd99d43
Merge commit '38691ee95c7f58918aa13264a8a9c91f52fe1355' into taa-only
JMS55 2aad44e
Fix merge
JMS55 d138306
Add con of TAA to docs
JMS55 dc291f0
Combine AA examples
JMS55 db2e5e5
Fix example metadata
JMS55 052817a
Doc note
JMS55 8812cd8
Change tonemapping solution for TAA
JMS55 7ae829f
Merge commit 'cf612c8349068c2250dddf8190cd9cc5c24763d8' into taa-only
JMS55 c461c26
const instead of let for globals in shaders
Elabajaba 769bd76
empty view_formats
Elabajaba 5f7fa7d
dx12 compiler and new limits
Elabajaba 9597c9a
surface creation
Elabajaba f60fc7a
wgpu release
Elabajaba e768e3e
default to DXC shader compiler
Elabajaba 9eab378
Srgb surface
Elabajaba eb5b86a
add DXC .dlls to .gitignore
Elabajaba a26a121
fix missed indented global let -> const
Elabajaba 9549bab
spelling
Elabajaba 9846dd9
Merge commit 'aab518af925e3f3b5d9b6a014faaab588ee43047' into taa-only
JMS55 236aa4e
Merge commit '9549bab349b50eb9d9b8c6b61791dd479eb62b50' into ssao
JMS55 f45ce48
Rebase fixes
JMS55 f1a5f09
Merge?
JMS55 13e1b97
spelling
Elabajaba 45ffa44
iter through formats to find the first good srgb one.
Elabajaba 94a8ccf
potential crash fix when MSAA is unsupported
Elabajaba e645332
fix wrong doc comment
Elabajaba 4818508
Merge commit 'e645332d5b2aeb43fb02979b58ecb462f660fdf5' into ssao
JMS55 675acec
whoops, forgot a /
Elabajaba b5269b3
WIP SSAO
JMS55 0048555
Merge commit '675acec9bce80bef6b66bc341d65476229dd351a' into ssao
JMS55 0907b6b
Refactor ssao texture creation
JMS55 75707e5
Fix weighted average of depths
JMS55 00594b7
Misc cleanup
JMS55 ad09b1a
Add SSAO documentation
JMS55 2c40dac
Add directional light to ssao example
JMS55 9c7bc40
Clarify ssao docs
JMS55 5409b3d
Appease clippy
JMS55 b0bed7b
Merge commit '1e591bf7a5b491ca699ebe1eb3736c04d3cdffb7' into taa-only
JMS55 230e5fc
Address review feedback
JMS55 2d3fb83
Fix NaNs
JMS55 21bbe66
Update crates/bevy_core_pipeline/src/prepass/mod.rs
JMS55 fe67b5a
Update crates/bevy_core_pipeline/src/prepass/mod.rs
JMS55 ea22039
Update crates/bevy_core_pipeline/src/taa/taa.wgsl
JMS55 dbbce60
Gate update_mesh_previous_global_transforms
JMS55 5091758
Use before() instead of at_start() for prepare_taa_jitter()
JMS55 d0108eb
Save 4 velocity samples per pixel
JMS55 c4faea1
Merge commit '12f30f56675220275568d5a51afd32f14e608fd4' into taa-only
JMS55 bcd0698
Don't allow reinserting taa bundle in example
JMS55 bcd7a5d
Add TAA reset
JMS55 13e8ea1
Migrate to stageless: Merge commit 'dcc03724a57e0980bb98d1b642e80fb2d…
JMS55 e9e0ef6
Prepare non-reset pipeline early
JMS55 1455078
Fix update_previous_view_projections
JMS55 039e081
Clear velocity to yellow
JMS55 d456a1f
Improve TAA docs
JMS55 ef0845f
Possible faster velocity clear
JMS55 42c3671
Add TODO about velocity format
JMS55 9a54c54
Merge commit '943499fcdf2301ea4091b8c4ebaa491dd8c26c33' into taa-only
JMS55 c845115
Fix schedule import
JMS55 47bf23f
Switch tonemapping to max3
JMS55 ce37025
Skip clipping when confident in history
JMS55 51a46da
Merge commit 'ce3702503796e17f239b06b453c5f79bded07091' into ssao
JMS55 c170fa6
TAA fix
JMS55 a577c23
Remove outdated doc comment
JMS55 5fd9c98
Move TAA to experimental module
JMS55 4366dd2
Misc rename
JMS55 d6eb01d
Instead of skipping clipping when confident in history, expand clippi…
JMS55 0fcab25
Merge commit 'd6eb01d7500b48d370dd7780f7fc986f78b7664d' into ssao
JMS55 0a01d05
Try other clipping approach
JMS55 2fe6d91
More conservative anti specular flicker
JMS55 52fc423
Reduce noise in static scenes
JMS55 4feab0e
Misc
JMS55 69c1dfe
Remove velocity_prepass_location
JMS55 c0acf54
Merge commit '69c1dfec0c747923c248579acbadc98d036804fe' into ssao
JMS55 58efd8f
Fix taa import
JMS55 0f5ccc5
Improve SSAO example sphere resolution
JMS55 e179e8a
Merge commit 'fefe5297ad00f93cc92df61153cb15dad3ae4857' into taa-only
JMS55 2cae300
Misc doc tweak
JMS55 61b9f78
Merge commit '2cae300a4985cafd51db1e0428f8d62fc9afcd57' into ssao
JMS55 87ef413
wip
IceSentry 557a278
Merge pull request #6 from IceSentry/taa-moving-sphere
JMS55 0df70a2
Revert "moving sphere"
JMS55 e516f88
Merge pull request #7 from JMS55/revert-6-taa-moving-sphere
JMS55 49e21f6
Misc example cleanup
JMS55 80ae486
Merge branch 'taa-only' of https://github.com/JMS55/bevy into taa-only
JMS55 e7e228e
Merge commit 'eaac730617103b61fd5ede9dca463243f2d7900e' into taa-only
JMS55 2fb3291
Tweak min history blend rate
JMS55 64a52bf
Misc refactor
JMS55 f388878
Increase history confidence faster
JMS55 8071f35
Merge branch 'taa-only' into ssao
JMS55 a10faa3
Update docs
JMS55 dd80e7c
Merge remote-tracking branch 'bevy/staging' into taa-only
JMS55 af38b4c
Tweak MIN_HISTORY_BLEND_RATE for smoother edges, at the cost of more …
JMS55 9f1a497
Tweak blend rate, probably for the final time
JMS55 5593ef9
Merge commit 'b24ed8bb0cf5567fd2467751d673754d102b47e4' into taa-only
JMS55 0f79160
Add MSAA sample count selection to AA example
JMS55 90725a2
Merge commit '3ec87e49ca49767fad658e72fbae353f6687198c' into taa-only
JMS55 191d1d8
Update Cargo.toml
JMS55 791460d
Consistent spelling of anti-aliasing
JMS55 6de0f46
Merge commit '15c55a12ff53c702acb167761424182f77f64dd7' into taa-only
JMS55 7c19b60
Rustfmt
JMS55 33012fb
Merge commit '9733613c07d65bc726f0eb1d955c363fb8e2b5c7' into taa-only
JMS55 56329de
Remove dead code
JMS55 de7d75b
Add neccesary command flush
JMS55 9891e8a
Misc
JMS55 68dbaf5
Revert "Misc"
JMS55 ea1840f
Shader ifdef fixes
JMS55 c416630
Rename velocity prepass to motion vector prepasss
JMS55 51631c0
Misc tweak
JMS55 b6d8b67
Merge remote-tracking branch 'bevyengine/main' into patch-taa
robtfm 8cbc894
fix target/attach vecs
robtfm 754192d
center jitter at zero
robtfm a7b0103
alpha-blend comment
robtfm 17771e5
ci
robtfm 81e9d29
Merge pull request #9 from robtfm/patch-taa
JMS55 aa0310e
Improve TAA jitter
JMS55 241875b
Update crates/bevy_pbr/src/prepass/mod.rs
JMS55 84cec18
Fix compile error
JMS55 04a9722
Fix shader_prepass
JMS55 415620d
Misc
JMS55 cccb2c2
Output motion vectors at render resolution, not ndc
JMS55 946f8d8
Add motion vectors to shader_prepass example
JMS55 66960e6
Fix label color in shader_prepass example
JMS55 ad4e19f
Revert "Output motion vectors at render resolution, not ndc"
JMS55 503deda
Fix update_mesh_previous_global_transforms() missing from schedule
JMS55 554c9a0
Update crates/bevy_pbr/src/prepass/mod.rs
JMS55 4af080c
Misc fixes
JMS55 2fb717e
Fix wrong system set
JMS55 fd5eeb5
Add comment
JMS55 d875e1c
Fix missing system
JMS55 6ec93f7
Improve show_prepass motion vectors
JMS55 d0ce763
Merge remote-tracking branch 'bevy/main' into taa-only
JMS55 7537c24
Fix shadow pass when no prepass is enabled
JMS55 9893d90
Misc formatting
JMS55 e289178
Merge commit '6124b20f4bb6c706f01c7a71259989696c91dea5' into taa-only
JMS55 c365924
Merge commit 'f3cf734659dc9e7f33e67364920231f1c51782dd' into taa-only
JMS55 15b050c
Merge commit '2908bb5e8a3ec00b883c7120a7a69f6e34bb642e' into taa-only
JMS55 784315c
Merge commit '15b050c6772a35401c2fba95d1c464441856533b' into ssao
JMS55 84c0664
Misc
JMS55 4dd6d63
Misc formatting
JMS55 956d825
Merge commit 'fd1af7c8b8a737b4da79615741f8844069bc6a5c' into taa-only
JMS55 4e96e73
Remove unnecsary trace
JMS55 a2b7e61
Fix typo
JMS55 e5b64a6
Misc fix
JMS55 9de0664
Merge commit 'e5b64a6fe5f0e0b1c6239a86108fa9b113c1aa89' into ssao
JMS55 31b15f5
Misc
JMS55 1295cb0
Merge commit '13196613ee3a1add2e525dc8d6a52d8534ebef81' into taa-only
JMS55 6242fd8
Update crates/bevy_core_pipeline/src/prepass/node.rs
JMS55 f61be1b
Doc tweak
JMS55 98baa5c
Misc refactor
JMS55 dc22250
Merge commit '7b7294b8a7c5f7531c52a2524a6a3a456c0519c0' into taa-only
JMS55 b3de57e
Merge commit 'caa662272ce91028cef6e237bb7c2a3e78727ef4' into taa-only
JMS55 765fa48
Misc fix
JMS55 4c03655
Merge commit '2c21d423fde265d1108270bd835b95a5164361cb' into taa-only
JMS55 12dd618
Remove view entity slot
JMS55 4227fa6
Update crates/bevy_core_pipeline/src/taa/taa.wgsl
JMS55 769b0af
Misc refactor
JMS55 a438db7
Merge branch 'taa-only' of https://github.com/JMS55/bevy into taa-only
JMS55 46aadc7
Rename TemporalAntialias -> TemporalAntiAlias
JMS55 b75aa88
Switch MOTION_VECTOR_PREPASS_FORMAT to Rg16Float
JMS55 a79cfdf
Doc comment
JMS55 6bb7fd2
Fix clip_towards_aabb_center
JMS55 c452322
Add docs for blend rates
JMS55 2479118
Misc
JMS55 8f6e0f7
Update docs
JMS55 3ae680c
Update crates/bevy_pbr/src/prepass/prepass.wgsl
JMS55 d4803b1
Update crates/bevy_pbr/src/render/pbr_prepass.wgsl
JMS55 6046146
Merge commit 'd4803b1331ea2356063147a2a67edb5ccc052d24' into ssao
JMS55 f786b5d
Rebase fixes
JMS55 3cc7389
Add ssao debug group
JMS55 302628b
Faster depth conversions
JMS55 08fbac1
Merge commit '53667dea56d24a17eb60b40bffc6baa1cdc8b063' into ssao
JMS55 7b8b981
Misc
JMS55 c16cc1a
Merge commit '09f1bd0be7bb1b6642dab989f1ebafe8807a1473' into ssao
JMS55 8d3294a
Fix rebase
JMS55 fc85c3f
Shader import improvement
JMS55 cbe314b
WIP bent normals (denoising broken)
JMS55 ebee98a
Merge commit '670f3f0dce2ced27388b10672d30594d399434e1' into ssao
JMS55 3d6eaee
Misc fix
JMS55 ca591f9
Revert "WIP bent normals (denoising broken)"
JMS55 2c1420a
Revert "Faster depth conversions"
JMS55 2d11c9f
Merge commit 'bc9144bcd68999fed29840a57c60c63b79ffc531' into ssao-mvp
JMS55 d4af1a9
Implement Plugin::finish()
JMS55 3bc851b
Cleanup using new APIs
JMS55 0bf5143
Merge commit '3bc851be36cd160a76a8b3fbcddca8ee189bf765' into ssao
JMS55 bc2b3e5
Add max_storage_textures_per_shader_stage check
JMS55 b621312
Remove visibility modifier
JMS55 814392a
Clarify error messages
JMS55 61a73f9
Merge commit 'd1158288d5977ccea8c87adf80359ff9e21a852e' into ssao
JMS55 9e6c18f
Merge remote-tracking branch 'prepass/main' into ssao
JMS55 82197ea
Misc docs
JMS55 b39b8c0
Update crates/bevy_pbr/src/ssao/mod.rs
JMS55 4ba6850
Apply PR feedback
JMS55 36cd601
Apply more PR feedback
JMS55 6039c18
handwritten bit pack/unpacking
Elabajaba 460baef
Merge pull request #12 from Elabajaba/ssao-bitpacking
JMS55 bb025a2
Refactor ssao settings
JMS55 e308d3b
Fix ssao example
JMS55 2e73f48
Add ssao platform docs
JMS55 b5256b9
Appease clippy
cart 04e800c
Fix ssao error message always triggering
JMS55 5e9b6bb
Tweak error message
JMS55 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.