Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Add reflect(skip_serializing) which retains reflection but disables automatic serialization #5250

Closed
wants to merge 23 commits into from
Closed

[Merged by Bors] - Add reflect(skip_serializing) which retains reflection but disables automatic serialization #5250

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
cf9b287
add `skip_serializing` flag to reflect macros
makspll Jul 7, 2022
d614252
add `skip_serializing` flag to reflect macros
makspll Jul 7, 2022
e249d97
rebase changes
makspll Sep 15, 2022
7089018
Merge branch 'no-serialize-attribute-reflect' of https://github.com/m…
makspll Sep 15, 2022
6f12dad
fixes for clippy
makspll Sep 15, 2022
d7ef6d8
remove needless test
makspll Sep 15, 2022
c83f3a1
Update crates/bevy_reflect/src/type_registry.rs
makspll Sep 18, 2022
3ff2831
Update crates/bevy_reflect/src/type_registry.rs
makspll Sep 18, 2022
a9fd824
Update crates/bevy_reflect/bevy_reflect_derive/src/derive_data.rs
makspll Sep 18, 2022
7f097d9
implement review changes
makspll Sep 18, 2022
0b3bddc
merge
makspll Sep 18, 2022
04c0a77
more review changes
makspll Sep 18, 2022
4ffdaf1
remove double reference from public API
makspll Sep 18, 2022
9d49b37
change doc comment
makspll Sep 18, 2022
dd8a10f
change spacing
makspll Sep 18, 2022
e3d1639
clippy fixes
makspll Sep 18, 2022
0d61a97
Update crates/bevy_reflect/src/serde/type_data.rs
makspll Sep 18, 2022
ad1521c
Update crates/bevy_reflect/src/serde/type_data.rs
makspll Sep 18, 2022
980daa3
implement further review changes
makspll Sep 18, 2022
4c8cd6f
Merge branch 'no-serialize-attribute-reflect' of https://github.com/m…
makspll Sep 18, 2022
6107749
further review implementation
makspll Sep 19, 2022
936fa0b
bring back dead_code markers
makspll Sep 19, 2022
dbc13d3
fix doc comments
makspll Sep 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update crates/bevy_reflect/src/type_registry.rs 
Co-authored-by: Gino Valente <49806985+MrGVSV@users.noreply.github.com>
  • Loading branch information
@makspll @MrGVSV
makspll and MrGVSV authored Sep 18, 2022
commit c83f3a113413b9ad973a0bb20e9e46bab6eebfe9
2 changes: 1 addition & 1 deletion crates/bevy_reflect/src/type_registry.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ impl SerializationData {
}
}
/// Returns true if the given index corresponds to a field meant to be ignored in serialization.
/// Indices start from 0 and ignored fields do not count as fields.
/// Indices start from 0 and ignored fields are skipped.
///
/// # Example
///
Expand Down