Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Fix size_hint for partially consumed QueryIter and QueryCombinationIter #5214

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - Fix size_hint for partially consumed QueryIter and QueryCombinationIter #5214

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3880ef5
Fix size_hint for partially consumed QueryIter
nicopap Jul 5, 2022
1c0b66d
Fix comment note
nicopap Jul 14, 2022
5ef7e5c
Rename remaning to be more explicit
nicopap Nov 1, 2022
ce115ff
Swap back binomial formula arguments
nicopap Nov 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Swap back binomial formula arguments
  • Loading branch information
@nicopap
nicopap authored Nov 15, 2022
commit ce115fff2730e46e5a61549c1eb062d70cb4d49c
2 changes: 1 addition & 1 deletion crates/bevy_ecs/src/query/iter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ impl<'w, 's, Q: ReadOnlyWorldQuery, F: ReadOnlyWorldQuery, const K: usize> Itera
}
let k = k.min(n - k);
let ks = 1..=k;
let ns = (n + 1 - k..=n).rev();
let ns = (n - k + 1..=n).rev();
ks.zip(ns)
.try_fold(1_usize, |acc, (k, n)| Some(acc.checked_mul(n)? / k))
}
Expand Down