Remove dead ParallelIterator code #4491
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All uses of ParallelIterator in the Query API were removed in bevyengine#1525, when it was replaced with Query::par_for_each(). This change removes the practically dead code related to ParallelIterator. It also updates the comments in the parallel_query example, which became out of date when ParallelIterator was replaced. It also increases the sprite count in the example, since sprite rendering is no longer a bottleneck. Finally, it fixes a bug in the example which caused sprites to get stuck on the edge of the window when the window's size was reduced.
|
Previous attempt in #2093. |
|
Whoops, thanks for the pointer @mockersf. I didn't realize there was a PR in the works which builds off ParallelIterator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All uses of ParallelIterator in the Query API were removed in #1525, when it was replaced with Query::par_for_each(). This change removes the practically dead code related to ParallelIterator.
It also updates the comments in the parallel_query example, which became out of date when ParallelIterator was replaced. It also increases the sprite count in the example, since sprite rendering is no longer a bottleneck. Finally, it fixes a bug in the example which caused sprites to get stuck on the edge of the window when the window's size was reduced.
Changelog