Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - bevy_reflect: ReflectFromPtr to create &dyn Reflect from a *const () #4475

Closed
wants to merge 20 commits into from
Closed

[Merged by Bors] - bevy_reflect: ReflectFromPtr to create &dyn Reflect from a *const () #4475

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
cddb930
bevy_reflect: ReflectFromPtr to create &dyn Reflect
jakobhellermann Apr 9, 2022
3038e3f
fix '# Safety' comment to be recognized by clippy
jakobhellermann Apr 18, 2022
6438f55
change names from to_ to as_ and get use *const dyn Reflect instead o…
jakobhellermann Apr 18, 2022
4665195
add more docs
jakobhellermann Apr 18, 2022
07b60d6
fix doctest
jakobhellermann Apr 18, 2022
e35f498
fix doctest again
jakobhellermann Apr 18, 2022
9553bfe
Merge branch 'main' into bevy-reflect-from-ptr
jakobhellermann May 3, 2022
b42b30f
Merge branch 'main' into bevy-reflect-from-ptr
jakobhellermann May 5, 2022
75bfd0a
use bevy_ptr
jakobhellermann May 5, 2022
0016eb1
Merge branch 'main' into bevy-reflect-from-ptr
jakobhellermann May 13, 2022
156f9f9
expose TypeId of ReflectFromPtr
jakobhellermann May 13, 2022
55fb2ea
change print in doctest to assert
jakobhellermann May 13, 2022
939d49f
use assert_eq on downcasted value
jakobhellermann May 13, 2022
31ec938
Apply suggestions from code review
jakobhellermann May 17, 2022
be78fd7
split complicated line into two
jakobhellermann May 17, 2022
b994928
remove unnecessary safety docs (they are required for the Ptr types)
jakobhellermann May 17, 2022
e51c5af
remove unnecessary methods from ReflectFromPtr
jakobhellermann May 17, 2022
a9ce062
Update crates/bevy_reflect/src/impls/std.rs
jakobhellermann May 17, 2022
bd91c13
Merge remote-tracking branch 'origin/main' into pr/jakobhellermann/44…
cart Jul 19, 2022
4b9e974
clippy
cart Jul 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix doctest
  • Loading branch information
@jakobhellermann
jakobhellermann committed Apr 18, 2022
commit 07b60d647ef5a70972438b909b06e32f25b58531
2 changes: 1 addition & 1 deletion crates/bevy_reflect/src/type_registry.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ impl<T: for<'a> Deserialize<'a> + Reflect> FromType<T> for ReflectDeserialize {
/// let value = Reflected("Hello world!".to_string());
/// let value: *const () = &value as *const _ as *const ();
///
/// let reflect_from_ptr = type_registry.get(std::any::TypeId::of::<Reflected>())?.data::<ReflectFromPtr>()?;
/// let reflect_from_ptr = type_registry.get(std::any::TypeId::of::<Reflected>()).unwrap().data::<ReflectFromPtr>().unwrap();
jakobhellermann marked this conversation as resolved.
Show resolved Hide resolved
/// // SAFE: `value` is a pointer to an valid value of `Reflected`
/// let value = unsafe { reflect_from_ptr.as_reflect_ptr(value) };
///
Expand Down