Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - #4231: panic when App::run() is called from Plugin::build() #4241

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - #4231: panic when App::run() is called from Plugin::build() #4241

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
87ea20c
#4231: panic when App::run() is called from Plugin::build()
Vrixyz Mar 17, 2022
6a8dcf0
#4241: fix PR feedbacks
Vrixyz Mar 18, 2022
956fdbb
Update crates/bevy_app/src/app.rs
Vrixyz May 16, 2022
aa4d904
add panic section to `App::run()`
Vrixyz May 18, 2022
171ab5b
#4231: add test
Vrixyz Dec 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update crates/bevy_app/src/app.rs 
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
  • Loading branch information
@Vrixyz @alice-i-cecile
Vrixyz and alice-i-cecile committed Dec 21, 2022
commit 956fdbb1d1e1fdedeb57acc9ebde43ae918a4c5c
1 change: 0 additions & 1 deletion crates/bevy_app/src/app.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ pub struct App {
plugin_registry: Vec<Box<dyn Plugin>>,
plugin_name_added: HashSet<String>,
/// A private marker to prevent incorrect calls to `App::run()` from `Plugin::build()`
/// <https://github.com/bevyengine/bevy/issues/4231>
is_building_plugin: bool,
}

Expand Down