Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Filter material handles on extraction #4178

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - Filter material handles on extraction #4178

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dd34813
Only extract SpecializedMaterial2d handles if they are visible
superdump May 2, 2022
a75fa80
Filter material handles on extraction
superdump Mar 8, 2022
1794083
bevy_pbr: Use clone_weak for material handles
superdump Mar 13, 2022
9b3d816
ExtractComponentPlugin: Support extracting the component only for vis…
superdump May 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Only extract SpecializedMaterial2d handles if they are visible
  • Loading branch information
@superdump
superdump committed May 2, 2022
commit dd34813f7bbfa433149df6a49069f60bbd7d5f1e
2 changes: 1 addition & 1 deletion crates/bevy_sprite/src/mesh2d/material.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ impl<M: SpecializedMaterial2d> Default for Material2dPlugin<M> {
impl<M: SpecializedMaterial2d> Plugin for Material2dPlugin<M> {
fn build(&self, app: &mut App) {
app.add_asset::<M>()
.add_plugin(ExtractComponentPlugin::<Handle<M>>::default())
.add_plugin(ExtractComponentPlugin::<Handle<M>>::extract_visible())
.add_plugin(RenderAssetPlugin::<M>::default());
if let Ok(render_app) = app.get_sub_app_mut(RenderApp) {
render_app
Expand Down