[Merged by Bors] - bevy_pbr: Optimize assign_lights_to_clusters#3984
Closed
superdump wants to merge 1 commit intobevyengine:mainfrom
Closed
[Merged by Bors] - bevy_pbr: Optimize assign_lights_to_clusters#3984superdump wants to merge 1 commit intobevyengine:mainfrom
superdump wants to merge 1 commit intobevyengine:mainfrom
Conversation
superdump
added
A-Rendering
alice-i-cecile
added
the
C-Performance
alice-i-cecile
approved these changes
Feb 18, 2022
Member
|
LGTM! |
robtfm
added a commit
to robtfm/bevy
that referenced
this pull request
Feb 19, 2022
mockersf
approved these changes
Feb 19, 2022
mockersf
added
the
S-Ready-For-Final-Review
Member
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 28, 2022
# Objective - Optimize assign_lights_to_clusters ## Solution - Avoid inserting entities into hash sets in inner loops when it is known they will be inserted in at least one iteration of the loop. - Use a Vec instead of a hash set where the set is not needed - Avoid explicit calculation of the cluster_index from x,y,z coordinates, instead using row and column offsets and just adding z in the inner loop - These changes cut the time spent in the system roughly in half
Contributor
bors
bot
changed the title
rparrett
pushed a commit
to rparrett/bevy
that referenced
this pull request
Mar 4, 2022
# Objective - Optimize assign_lights_to_clusters ## Solution - Avoid inserting entities into hash sets in inner loops when it is known they will be inserted in at least one iteration of the loop. - Use a Vec instead of a hash set where the set is not needed - Avoid explicit calculation of the cluster_index from x,y,z coordinates, instead using row and column offsets and just adding z in the inner loop - These changes cut the time spent in the system roughly in half
kurtkuehnert
pushed a commit
to kurtkuehnert/bevy
that referenced
this pull request
Mar 6, 2022
# Objective - Optimize assign_lights_to_clusters ## Solution - Avoid inserting entities into hash sets in inner loops when it is known they will be inserted in at least one iteration of the loop. - Use a Vec instead of a hash set where the set is not needed - Avoid explicit calculation of the cluster_index from x,y,z coordinates, instead using row and column offsets and just adding z in the inner loop - These changes cut the time spent in the system roughly in half
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution