Bevy shapes by JasmineLowen · Pull Request #25302 · bevyengine/bevy

JasmineLowen · 2026-08-05T19:27:41Z

Objective

Same goal as Split out parts of bevy_math into bevy_shape and bevy_geometry #25047, supersedes it
Split up bevy_math into bevy_math and bevy_shape (geometry focused)

Solution

Mainly move over all the primitives and related structs
bevy_shape depends on bevy_math
bevy_shape also includes other primitive related things like rays and primitive related traits

Testing

CI is green except for some weird failures that are unrelated to the PR itself
Run tests & co

Todos

migration guide
~~maybe improve prelude?~~

Smerom

Looks to be a clean move of the primitive shapes out of the math crate.

JasmineLowen · 2026-08-11T05:45:02Z

+/// The shape prelude.
+///
+/// This includes all primitive shape types in this crate, re-exported for your convenience.
+pub mod prelude {
+    // just re-export everything, it's just shape definitions anyways
+    #[doc(hidden)]
+    pub use crate::*;
+}


let me know if we should be more specific here

IQuick143 · 2026-08-11T11:20:36Z

+impl Primitive2d for bevy_math::Dir2 {}
+impl Primitive3d for bevy_math::Dir3 {}
+impl Primitive3d for bevy_math::Dir3A {}


These impls are super weird to me, why do we have them?
Regardless, they're not the fault of this PR, it just keeps them as they were.

I think this is for rendering the structs with gizmos. They have special rendering (arrows) when rendered via the primitives gizmos API.

IQuick143 · 2026-08-11T11:22:45Z

 fn xy_order(a: Vec2, b: Vec2) -> Ordering {
    a.x.total_cmp(&b.x).then_with(|| a.y.total_cmp(&b.y))
 }

 /// The event queue holds an ordered list of all events the [`SweepLine`] will encounter when checking the current polygon.
-#[cfg(feature = "alloc")]


Why drop the feature gates?

Everything in the module was feature gated with alloc. The only thing that wasn't was marked as dead code. I thought that this is a bit silly so I just feature gated the whole module instead.

See latest state on main without the changes for a clearer picture:

https://github.com/bevyengine/bevy/blob/1f7cbb6674148bee59e353d9763c11ba02c6a5dd/crates/bevy_math/src/primitives/polygon.rs

IQuick143 · 2026-08-11T11:24:38Z

Gave it a quick skim, seems generally good, with a few minor things. Will 100% need a migration guide for users to switch imports to the new crate.

Based-A

Couple questions, but otherwise everything looks good from my perspective :)

Based-A · 2026-08-11T18:36:35Z

+        let [a, b, c] = [vertices[0], vertices[1], vertices[2]];
+        let triangle_area =
+            ops::abs(a.x * (b.y - c.y) + b.x * (c.y - a.y) + c.x * (a.y - b.y)) / 2.0;
+        return triangle_area > 0.0;


Is using a Triange2d here not preferred anymore?

It's due to a dependency reason. This PR is a shorter version of the one mentioned in the description. The area method on Triangle2d is a trait method.

@NiseVoid proposed moving the Bounding-related traits out into yet another crate.

In my last attempt, this other crate bevy_geometry (working-crate-name, not final) had a dependency on bevy_shape because it was making use of the Circle and Sphere structs for bounding volumes and it was also containing the implementations of all its traits for the bevy_shapes.

Importing the Bounding trait here to make use of the area method would lead to a circular dependency. So in the end this is for decoupling reasons.

I don't mind reverting it if it is a thorn in your eyes.

Gotcha, that makes sense. No need to revert from my perspective

Based-A · 2026-08-11T19:16:50Z

 use bevy::{
    color::palettes::css::{BLUE, GRAY, RED},
-    math::{
-        bounding::{Bounded2d, BoundingVolume},


I'm guessing these shapes/primitives are included in the prelude now?

These are traits that were previously not included in the math prelude for some odd not-documented reason. At this point I'm just guessing it is an oversight.

When asking on discord, noone responded except @Jondolf :

I don't think there's any particular reason, I'd be fine with adding all the common bounding types and traits to the prelude

So this is why there are changes like this all over the place.

Nice, yeah just double checking.

JasmineLowen · 2026-08-12T18:26:37Z

Added the migration guide. Now also up for review

Smerom

Couple proofread comments on the migration, but otherwise looks good!

JasmineLowen · 2026-08-13T15:53:20Z

Thanks @Smerom, I applied the suggestions

Zeophlite · 2026-08-25T11:43:36Z

@JasmineLowen Could you merge main?

JasmineLowen · 2026-09-01T18:01:03Z

+pub mod prelude {
+    // just re-export everything, it's just shape definitions anyways
+    #[doc(hidden)]
+    pub use crate::*;
+}


This was a mistake btw, this lead to:

https://github.com/bevyengine/bevy/actions/runs/33535695284/job/99949477868?pr=25380

I'm going to fix it up in:

#25380

# Objective - the bevy_curve / bevy_shape split (bevyengine#25380 / bevyengine#25302) had a few issues - missing licenses files - tool generating images didn't update path - bevy_animation needs bevy_curve/reflect - some alloc gates in bevy_curve seem wrong - dependencies are not specified in the same order as other crates ## Solution - fix them

JasmineLowen force-pushed the bevy-shapes branch 2 times, most recently from f10b34d to 4ea8710 Compare August 6, 2026 15:10

JaySpruce added C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Math Fundamental domain-agnostic mathematical operations S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Aug 6, 2026

JasmineLowen marked this pull request as ready for review August 6, 2026 18:16

JaySpruce added S-Needs-Review Needs reviewer attention (from anyone!) to move forward and removed S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Aug 6, 2026

Smerom reviewed Aug 9, 2026

View reviewed changes

Comment thread crates/bevy_math/Cargo.toml

JasmineLowen force-pushed the bevy-shapes branch from 4ea8710 to 5dae0b8 Compare August 11, 2026 05:39

JasmineLowen commented Aug 11, 2026

View reviewed changes

Comment thread crates/bevy_math/src/sampling/standard.rs

JasmineLowen commented Aug 11, 2026

View reviewed changes

IQuick143 added C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples labels Aug 11, 2026

IQuick143 reviewed Aug 11, 2026

View reviewed changes

Comment thread crates/bevy_gizmos/src/primitives/dim3.rs Outdated

IQuick143 reviewed Aug 11, 2026

View reviewed changes

Comment thread crates/bevy_gizmos/src/primitives/mod.rs Outdated

IQuick143 reviewed Aug 11, 2026

View reviewed changes

IQuick143 added the M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide label Aug 11, 2026

JasmineLowen force-pushed the bevy-shapes branch from 5dae0b8 to 64966ed Compare August 11, 2026 16:31

JasmineLowen requested a review from IQuick143 August 11, 2026 16:32

JasmineLowen force-pushed the bevy-shapes branch from 64966ed to 36e3af3 Compare August 11, 2026 16:34

Based-A reviewed Aug 11, 2026

View reviewed changes

JasmineLowen requested a review from Based-A August 12, 2026 06:33

Based-A approved these changes Aug 12, 2026

View reviewed changes

Smerom reviewed Aug 13, 2026

View reviewed changes

Comment thread _release-content/migration-guides/bevy_shape.md Outdated

Smerom reviewed Aug 13, 2026

View reviewed changes

Comment thread _release-content/migration-guides/bevy_shape.md Outdated

Smerom approved these changes Aug 13, 2026

View reviewed changes

JasmineLowen force-pushed the bevy-shapes branch from 70ff10e to 6e15856 Compare August 13, 2026 15:52

JasmineLowen added 5 commits August 25, 2026 19:48

move shapes related modules, structs and trait to bevy_shape

7cc3534

implement external traits (meshable + gizmos render)

8e3358c

fixup external crates, benches, examples, tests, docs

72d23a3

put bounding module contents in prelude

4fda3d7

write migration guide for bevy_shape

724b681

JasmineLowen force-pushed the bevy-shapes branch from 6e15856 to 724b681 Compare August 25, 2026 17:53

JaySpruce removed the S-Merge-Conflicts Merge conflicts :( Add this label on top of other S- labels. label Aug 25, 2026

alice-i-cecile added the X-Blessed Has a large architectural impact or tradeoffs, but the design has been endorsed by decision makers label Aug 31, 2026

alice-i-cecile added this pull request to the merge queue Aug 31, 2026

Merged via the queue into bevyengine:main with commit 5ccb729 Aug 31, 2026
44 checks passed

JasmineLowen deleted the bevy-shapes branch September 1, 2026 06:21

JasmineLowen commented Sep 1, 2026

View reviewed changes

mockersf mentioned this pull request Sep 2, 2026

Bevy curve/shape cleanup #25651

Merged

Uh oh!

Uh oh!

Conversation

JasmineLowen commented Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Objective

Solution

Testing

Todos

Uh oh!

Smerom left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JasmineLowen Aug 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

IQuick143 commented Aug 11, 2026

Uh oh!

Based-A left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JasmineLowen commented Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Smerom left a comment

Choose a reason for hiding this comment

Uh oh!

JasmineLowen commented Aug 13, 2026

Uh oh!

Zeophlite commented Aug 25, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

JasmineLowen commented Aug 5, 2026 •

edited

Loading

JasmineLowen Aug 11, 2026 •

edited

Loading

JasmineLowen commented Aug 12, 2026 •

edited

Loading